1256270 - Resource leaks in tls_connect.cc

Status: RESOLVED INVALID

(NSS :: Test, defect)

Description

[Franziskus Kiefer [:franziskus]]

The constructor of TlsConnectTestBase initialises the following without freeing it in the deconstructor.

> client_(new TlsAgent("client", TlsAgent::CLIENT, mode_, ssl_kea_rsa)),
> server_(new TlsAgent("server", TlsAgent::SERVER, mode_, ssl_kea_rsa)),

Comment 1

[Franziskus Kiefer [:franziskus]]

Attachment: sslGtestTearDown.patch

we should make to sure to call TearDown in case the object is destroyed before TearDown is called.

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 8732783 [details] [diff] [review]
sslGtestTearDown.patch

Review of attachment 8732783 [details] [diff] [review]:
-----------------------------------------------------------------

TearDown() is automatically called by the framework

Comment 3

[Franziskus Kiefer [:franziskus]]

(In reply to Eric Rescorla (:ekr) from comment #2)
> Comment on attachment 8732783 [details] [diff] [review]
> sslGtestTearDown.patch
> 
> Review of attachment 8732783 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> TearDown() is automatically called by the framework

this is more about the logic (if initializing things in the constructor, we should free it in the destructor). But let's flag it false positive.