Closed
Bug 1256288
Opened 9 years ago
Closed 9 years ago
Remove unused class Divider
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: sebastian, Assigned: write2umeshkumhar, Mentored)
Details
(Whiteboard: [lang=java][good first bug])
Attachments
(1 file)
|
2.66 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
The org.mozilla.gecko.widget.Divider class is unused.
To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build
To fix this bug, you need to remove this class:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/widget/Divider.java
And then update this build file:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/moz.build#595
Finally you'll need to create a patch to upload - see
https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Hi,I would like to work on what my bug first ,but I have a question about this bug .
is that the removing this class will solve the bug?
Thanks .
Flags: needinfo?(bouzroudzeineb)
|
Reporter | |
Comment 2•9 years ago
|
||
(In reply to Bouzroud_Saidani from comment #1)
> Hi,I would like to work on what my bug first ,but I have a question about
> this bug .
> is that the removing this class will solve the bug?
> Thanks .
Yeah, correct. To fix this bug you need to delete the class and update the build file mentioned in comment 0.
|
Assignee | |
Comment 3•9 years ago
|
||
hi please review the patch :-)
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8730416 -
Flags: review?(s.kaspari)
|
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → write2umeshkumhar
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8730416 [details] [diff] [review]
1256288.patch
Review of attachment 8730416 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Thank you!
Attachment #8730416 -
Flags: review?(s.kaspari) → review+
|
|
Reporter | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/bb1b3fcdaaa5e0c2f6e2b67e338972bd70db8765
Bug 1256288 - Remove unused class Divider. r=sebastian
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•