Closed Bug 1256290 Opened 4 years ago Closed 4 years ago

test_crash_manager.jsm fails locally because of a round-trip failure in the environment (GPUActive: undefined)

Categories

(Toolkit :: Telemetry, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: benjamin, Assigned: benjamin)

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

On my local Windows machine, test_crash_manager.jsm always fails at:

Assert.deepEqual(found.environment, theEnvironment, "The saved environment should be present");

I dumped these objects and the difference is a property  system.gfx.adapters[1].GPUActive === undefined

Since undefined props disappear when round-tripped through JSON, the serialized version doesn't exactly match.

The code path that gets this value is:
http://hg.mozilla.org/mozilla-central/annotate/f0c0480732d3/toolkit/components/telemetry/TelemetryEnvironment.jsm#l1319

Which pulls a property off nsIGfxInfo but I'm pretty sure there just shouldn't be an extra space in the prop name at 1319. I'm going to fix getGfxField to be less tolerant of undefined values.
Priority: -- → P3
Whiteboard: [measurement:client]
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Comment on attachment 8730226 [details]
MozReview Request: Bug 1256290 - isGPUActive for the second graphics adapter doesn't work correctly, and this also means we should tighten up getGfxField a little bit r?gfritzsche

https://reviewboard.mozilla.org/r/39761/#review36553

Thanks.
Attachment #8730226 - Flags: review?(gfritzsche) → review+
https://hg.mozilla.org/mozilla-central/rev/dce690007f02
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.