1256299 - Add isSameNode() back to Node

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=687400#c31

Comment 1

[John Dai[:jdai]]

I would like to try on this bug.

Comment 2

[John Dai[:jdai]]

Attachment: Bug 1256299 - Implement Node.isSameNode.

Comment 3

[John Dai[:jdai]]

Attachment: Bug 1256299 - Remove redundent trailing spaces.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8733246 [details] [diff] [review]
Bug 1256299 - Implement Node.isSameNode.

>+nsINode::IsSameNode(nsIDOMNode* aOther, bool* aReturn)

You don't need this function.

>+  NS_IMETHOD IsSameNode(nsIDOMNode* aArg, bool* aResult) __VA_ARGS__ override \

Or this bit.

>+++ b/dom/interfaces/core/nsIDOMNode.idl

Because you don't want to add anything to this file.  nsIDOMNode is deprecated; we should slowly be removing things from it, not adding them.

r=me with that fixed.  Thank you for picking this up!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8733247 [details] [diff] [review]
Bug 1256299 - Remove redundent trailing spaces.

r=me

Comment 6

[John Dai[:jdai]]

Attachment: Bug 1256299 - Implement Node.isSameNode. r=bz

Thanks for your review and valuable feedback. I addressed all of them into my patch.

Comment 7

[John Dai[:jdai]]

Attachment: Bug 1256299 - Remove redundent trailing spaces. r=bz

Comment 8

[John Dai[:jdai]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0a4168c33cc&filter-tier=1

Comment 9

[Carsten Book [:Tomcat]]

adding 1256299 to series file
renamed 1256299 -> bug_1256299_1.patch
applying bug_1256299_1.patch
patching file dom/base/nsINode.cpp
Hunk #1 FAILED at 970
1 out of 1 hunks FAILED -- saving rejects to file dom/base/nsINode.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug_1256299_1.patch

could you take a look, thanks!

Comment 10

[John Dai[:jdai]]

Sorry for the inconvenience, I didn't expect my patches can't apply to m-i. I will fix that and re-land my patch.

Comment 11

[John Dai[:jdai]]

Attachment: Bug 1256299 - Remove redundent trailing spaces.(Final) r=bz

I didn't modify any code, only changed patch order. Those patches can apply on m-c and m-i.

Try result:https://treeherder.mozilla.org/#/jobs?repo=try&revision=32b78ffb4284&filter-tier=1

Comment 12

[John Dai[:jdai]]

Attachment: Bug 1256299 - Implement Node.isSameNode. (Final) r=bz

Comment 13

[John Dai[:jdai]]

Attachment: Part 1: Bug 1256299 - Implement Node.isSameNode. (Final) r=bz

Comment 14

[John Dai[:jdai]]

Attachment: Part 2: Bug 1256299 - Remove redundent trailing spaces.(Final) r=bz

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c6bed47abd4
https://hg.mozilla.org/integration/mozilla-inbound/rev/2706aaa4d078

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7c6bed47abd4
https://hg.mozilla.org/mozilla-central/rev/2706aaa4d078

Comment 17

[Eric Shepherd [:sheppy]]

Updated documents:

https://developer.mozilla.org/en-US/docs/Web/API/Node/isSameNode
https://developer.mozilla.org/en-US/docs/Web/API/Node/isEqualNode
https://developer.mozilla.org/en-US/docs/Web/API/Node

Added this change to Firefox 48 for developers:

Comment 18

[Eric Shepherd [:sheppy]]

The missing link to Fx 48 for devs: https://developer.mozilla.org/en-US/Firefox/Releases/48#DOM_HTML_DOM

Comment 19

[Jean-Yves Perrier [:teoli]]

Reopening the docs part. 

Eric: there is no example in https://developer.mozilla.org/en-US/docs/Web/API/Node/isSameNode and the spec table is the 2010 version (and no browser compat table) in https://developer.mozilla.org/en-US/docs/Web/API/Node/isEqualNode

Also in all the Node pages sidebar, isSameNode is still marked as deprecated.

Also add the bug number to the entry in Firefox 48 for developers.

Thank you.

Comment 20

[Eric Shepherd [:sheppy]]

Yeah, true! All I did was update the compatibility information -- I made no other changes to the page. I intentionally avoided making other changes because when I do, you tend to complain that I'm deviating from my deliverables by doing more than necessary to close the specific bug at hand. :)

I'll start doing more thorough updates to these pages going forward when I touch them.

Comment 21

[Eric Shepherd [:sheppy]]

OK, all of this should now be fixed.