Closed Bug 1256343 Opened 4 years ago Closed 4 years ago

autophone should add --subsuite=media to run dom/media mochitests

Categories

(Testing :: Autophone, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: bc)

References

Details

Attachments

(2 files)

we modified the mochitest manifests to have |suite = media| for all mochitests in dom/media/*

this is solved by adding --subsuite=media to the manifest parser for desktop mochitests.
I don't understand what you mean by "adding --subsuite=media to the manifest parser for desktop mochitests". My first though would have been to add an optional test_subsuite to the mochitest config files in configs/ and to add it to the arguments passed to mochitest/run*.py if it exists.
Flags: needinfo?(jmaher)
Blocks: 1242682
I envision a fix that looks like:
https://pastebin.mozilla.org/8863602

how to solve builds on version <48 will not be as trivial, but doable.
Flags: needinfo?(jmaher)
Assignee: nobody → bob
Status: NEW → ASSIGNED
Comment on attachment 8730681 [details] [diff] [review]
bug-1256343-v1.patch

Review of attachment 8730681 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit for comments.

::: tests/runtestsremote.py
@@ +224,5 @@
> +            try:
> +                manifest_cfg = ConfigParser.RawConfigParser()
> +                manifest_cfg.read("%s/tests/%s" % (
> +                    self.parms['build_dir'], self.parms['test_manifest']))
> +                test_subsuite = manifest_cfg.get('DEFAULT', 'subsuite')

this is a nice way to solve the problem, a comment here would help make it understandable to someone looking at this for the first time.  Specifically that we sometimes have subsuite and if we have it we will use it, otherwise throw an exception.
Attachment #8730681 - Flags: review?(jmaher) → review+
I've added the following comment. Ping me quick if you want to change it:

+            # Check if the test manifest defines a subsuite which
+            # should be specified. Although we normally parse these
+            # manifests with manifestparser, that is overkill for our
+            # needs. Using the normal ConfigParser we can determine
+            # the subsuite value if it is defined and add the subsuite
+            # command line argument. Missing section or option errors
+            # simply mean no subsuite is defined.
looks great, thanks!
https://github.com/mozilla/autophone/commit/e15ff66a2d3b63299f22314789c58014211b9ae9

deployed 2016-03-15 06:29
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Need to add subsuite to testing/mochitest/manifests/autophone-media.ini as well.
Attachment #8730761 - Flags: review?(jmaher)
Comment on attachment 8730761 [details] [diff] [review]
bug-1256343-autophone-media-manifest.patch

Review of attachment 8730761 [details] [diff] [review]:
-----------------------------------------------------------------

ah, good catch!
Attachment #8730761 - Flags: review?(jmaher) → review+
deployed 2016-03-15 ~22:46
doh, deployed 2016-03-16 ~22:46
You need to log in before you can comment on or make changes to this bug.