1256371 - WebGL is non functional

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: major web feature broken

I have tested several webgl sites and they all report that webgl is non functional.

http://get.webgl.org/
http://doesmybrowsersupportwebgl.com/

From https://support.mozilla.org/en-US/questions/1114216

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Works here on Nexus 6P. What hardware are you on?

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Works on Nexus 9 and Nexus 4 as well. Not sure what's going on, but logcat from an affected device may help.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Kevin says he says 'GLContext is disabled' type of messages in the logcat, presumably due to the crashes. Milan, I think it makes sense to just disable that stuff on Android, sense no configuration changes (driver upgrades) are really possible.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Attachment: 1256371.txt

Full logcat

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Milan is PTO this week, redirecting to dvander who I believe is working on this stuff.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Sounds reasonable.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8730363 [details] [diff] [review]
patch

Review of attachment 8730363 [details] [diff] [review]:
-----------------------------------------------------------------

Will this also enable WebGL for people where it has been disabled by the crash guard?

Comment 8

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #7)
> Comment on attachment 8730363 [details] [diff] [review]
> patch
> 
> Review of attachment 8730363 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Will this also enable WebGL for people where it has been disabled by the
> crash guard?

Yup.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8730363 [details] [diff] [review]
patch

Review of attachment 8730363 [details] [diff] [review]:
-----------------------------------------------------------------

We'll want to uplift this basically everywhere, including release if there is a dot release

Comment 10

[Sylvestre Ledru [:Sylvestre]]

James, David, I am going to start the build of dot release very soon, could you fill the uplift request? Thanks

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a1e75dd9d54

Comment 12

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8730363 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1190281
[User impact if declined]: No WebGL support for users where WebGL crashed.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: No risk, aside from unblocking WebGL for users where it once crashed, so there's a chance they may crash again. This isn't anywhere near as severe as a startup crash which is what the guard was intended to prevent.
[String/UUID change made/needed]:

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8730363 [details] [diff] [review]
patch

Needed for 45.0.1 fennec

Ryan, very sorry but could you land that? Thanks

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I can get it.

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Here's release, I'll get the other trees when I look through the rest of the uplift requests:

https://hg.mozilla.org/releases/mozilla-release/rev/910c9ac881ee

Comment 16

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/7773387a9a2f

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7773387a9a2f

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a1e75dd9d54

Comment 19

[Sylvestre Ledru [:Sylvestre]]

Added to the release notes with "Bring back WebGL support on some devices (1256371)" as wording

Comment 20

[Carsten Book [:Tomcat]]

(In reply to Carsten Book [:Tomcat] from comment #18)
> https://hg.mozilla.org/mozilla-central/rev/5a1e75dd9d54

dvander so this is the final patch that needs to land on beta and co ?

Comment 21

[u421692]

I was able to reproduce this issue on Firefox 45.0 with the following STR: 
1. Install crashme add-on
2. Open http://get.webgl.org/ the very quickly crash Firefox
1/2 times I was able to reproduce the issue

Verified as fixed on Firefox 45.0.1 following the STR from above, and wasn't able to reproduce at all.

Comment 22

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Carsten Book [:Tomcat] from comment #20)
> (In reply to Carsten Book [:Tomcat] from comment #18)
> > https://hg.mozilla.org/mozilla-central/rev/5a1e75dd9d54
> 
> dvander so this is the final patch that needs to land on beta and co ?

Yup.

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/85a96d03d818

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6b7212e05883