1256401 - Remove the b2gdroid sub-product from the tree

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks removing the b2gdroid sub-product from the tree entirely.  The effort is no longer funded and it adds some cost to other Fennec build work (including Bug 1255925, which seeks to completely overhaul Fennec's build steps).

b2gdroid was added by Bug 1180358.

Comment 1

[Tom S]

I don't think Bug 1255925 is what you are looking for.

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Tom Schuster [:evilpie] from comment #1)
> I don't think Bug 1255925 is what you are looking for.

Thanks Tom, my mistake.

Comment 3

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2256e0a12588

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1256401 - Part 1: Remove mobile/android/b2gdroid. r?fabrice

Review commit: https://reviewboard.mozilla.org/r/41159/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41159/

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1256401 - Part 2: Remove references to b2gdroid. r?fabrice

Review commit: https://reviewboard.mozilla.org/r/41161/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41161/

Comment 6

[Nick Alexander :nalexander [he/him]]

fabrice: there's a little bit more to back out from Back out the rest of https://hg.mozilla.org/mozilla-central/filelog/3e04659fdf6aef792f7cf9840189c6c38d08d1e8/dom/apps/AndroidUtils.jsm.  Some stuff with "kAndroid".  Could you prepare whatever patch is appropriate there?

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 8732391 [details]
MozReview Request: Bug 1256401 - Part 1: Remove mobile/android/b2gdroid. r?fabrice

https://reviewboard.mozilla.org/r/41159/#review37967

Comment 8

[[:fabrice] Fabrice Desré]

Comment on attachment 8732392 [details]
MozReview Request: Bug 1256401 - Part 2: Remove references to b2gdroid. r?fabrice

https://reviewboard.mozilla.org/r/41161/#review37987

::: old-configure.in:6323
(Diff revision 1)
>    AC_DEFINE(MOZ_DISABLE_STARTUPCACHE)
>  fi
>  AC_SUBST(MOZ_DISABLE_STARTUPCACHE)
>  
> -dnl ========================================================
> -dnl = Enable packaging Gaia with B2G desktop and b2gdroid
> +dnl =========================================
> +dnl = Enable packaging Gaia with B2G desktop 

nit: trailing white space

Comment 9

[[:fabrice] Fabrice Desré]

(In reply to Nick Alexander :nalexander from comment #6)
> fabrice: there's a little bit more to back out from Back out the rest of
> https://hg.mozilla.org/mozilla-central/filelog/
> 3e04659fdf6aef792f7cf9840189c6c38d08d1e8/dom/apps/AndroidUtils.jsm.  Some
> stuff with "kAndroid".  Could you prepare whatever patch is appropriate
> there?

We're gonna remove all of dom/apps in the near future anyway, so that will take care of that.

Comment 10

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/315db5f647123174c75253dfd01b5b079789d3f2
Bug 1256401 - Part 1: Remove mobile/android/b2gdroid. r=fabrice

https://hg.mozilla.org/integration/fx-team/rev/a85b572e0d8cb461253363dc8ac9bfc2f60d953d
Bug 1256401 - Part 2: Remove references to b2gdroid. r=fabrice

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/315db5f64712
https://hg.mozilla.org/mozilla-central/rev/a85b572e0d8c