Closed Bug 1256411 Opened 7 years ago Closed 7 years ago

simplify and cleanup ServiceWorkerInfo

Categories

(Core :: DOM: Service Workers, defect)

Product:
Core
Component:
DOM: Service Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox45 --- wontfix
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed
firefox-esr45 --- wontfix

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

Simplify and cleanup ServiceWorkerInfo. r=ehsan
5.33 KB, patch
ehsan.akhgari
: review+
ritu
: approval-mozilla-aurora+
ritu
: approval-mozilla-beta+
Details | Diff | Splinter Review 
While working on other bugs I noticed some things we can simplify in ServiceWorkerInfo.  Some dead code and unnecessarily complex object dependencies.
Attachment #8730343 - Flags: review?(ehsan) → review+
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan

Approval Request Comment
[Feature/regressing bug #]: Service workers.
[User impact if declined]: I'd like to uplift this to make other future uplifts easier.  It also removes some code that could be theoretically lead to crashes.
[Describe test coverage new/current, TreeHerder]: Existing mochitests and wpt tests.
[Risks and why]: Minimal.
[String/UUID change made/needed]: None
Attachment #8730343 - Flags: approval-mozilla-beta?
Attachment #8730343 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/1ad42fbbe29a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan

While code cleanup should ideally ride the trains, given that this will help simplify future bug fixes and we have good automated test coverage, I am ok to take it in Aurora47.
Attachment #8730343 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan

We should also uplift to Beta46.
Attachment #8730343 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.