simplify and cleanup ServiceWorkerInfo

RESOLVED FIXED in Firefox 46

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox45 wontfix, firefox46 fixed, firefox47 fixed, firefox48 fixed, firefox-esr45 wontfix)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
While working on other bugs I noticed some things we can simplify in ServiceWorkerInfo.  Some dead code and unnecessarily complex object dependencies.
(Assignee)

Comment 1

3 years ago
Created attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69b0a31392d1
Attachment #8730343 - Flags: review?(ehsan)

Updated

3 years ago
Attachment #8730343 - Flags: review?(ehsan) → review+
(Assignee)

Updated

3 years ago
status-firefox45: --- → wontfix
status-firefox46: --- → affected
status-firefox47: --- → affected
status-firefox48: --- → affected
status-firefox-esr45: --- → wontfix
(Assignee)

Comment 3

3 years ago
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan

Approval Request Comment
[Feature/regressing bug #]: Service workers.
[User impact if declined]: I'd like to uplift this to make other future uplifts easier.  It also removes some code that could be theoretically lead to crashes.
[Describe test coverage new/current, TreeHerder]: Existing mochitests and wpt tests.
[Risks and why]: Minimal.
[String/UUID change made/needed]: None
Attachment #8730343 - Flags: approval-mozilla-beta?
Attachment #8730343 - Flags: approval-mozilla-aurora?

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1ad42fbbe29a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Comment 5

3 years ago
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan

While code cleanup should ideally ride the trains, given that this will help simplify future bug fixes and we have good automated test coverage, I am ok to take it in Aurora47.
Attachment #8730343 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 6

3 years ago
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan

We should also uplift to Beta46.
Attachment #8730343 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 7

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/888d64f75c9d
status-firefox47: affected → fixed

Comment 8

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/56d07f9b4d61
status-firefox46: affected → fixed
You need to log in before you can comment on or make changes to this bug.