Closed Bug 1256482 Opened 4 years ago Closed 4 years ago
.h(59): warning C4312: 'reinterpret _cast': conversion from 'DWORD' to 'HANDLE' of greater size
58 bytes, text/x-review-board-request
We're hitting this compilation warning turned into error when building with VS2015. Although the header referenced is in third party code, we see the error when building our WebRTC integration code in dom/media/webrtc.
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings, of course. Given that the warning is in WebRTC which is third party code, there isn't much we can do about the warning. However, Google is building Chrome with Visual Studio 2015, so I wouldn't be surprised if this were fixed upstream or will be fixed upstream. Then again, we allow warnings when building WebRTC. So perhaps not. Review commit: https://reviewboard.mozilla.org/r/39859/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39859/
Attachment #8730430 - Flags: review?(rjesup)
Comment on attachment 8730430 [details] MozReview Request: Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r?jesup https://reviewboard.mozilla.org/r/39859/#review36503
Attachment #8730430 - Flags: review?(rjesup) → review+
You need to log in before you can comment on or make changes to this bug.