1256482 - media\webrtc\trunk\webrtc/base/criticalsection.h(59): warning C4312: 'reinterpret_cast': conversion from 'DWORD' to 'HANDLE' of greater size

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Gregory Szorc [:gps]]

We're hitting this compilation warning turned into error when building with VS2015. Although the header referenced is in third party code, we see the error when building our WebRTC integration code in dom/media/webrtc.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r?jesup

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings, of course.

Given that the warning is in WebRTC which is third party code, there
isn't much we can do about the warning. However, Google is building
Chrome with Visual Studio 2015, so I wouldn't be surprised if this
were fixed upstream or will be fixed upstream. Then again, we allow
warnings when building WebRTC. So perhaps not.

Review commit: https://reviewboard.mozilla.org/r/39859/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39859/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8730430 [details]
MozReview Request: Bug 1256482 - Disable C4312 to unblock compilation on VS2015; r?jesup

https://reviewboard.mozilla.org/r/39859/#review36503

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df2429673c94

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df2429673c94