Closed Bug 1256492 Opened 4 years ago Closed 4 years ago

gfx/gl/SharedSurfaceEGL.cpp(42): warning C4312: 'reinterpret_cast': conversion from 'GLuint' to 'EGLClientBuffer' of greater size

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gps, Assigned: jgilbert)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file, 1 obsolete file)

We're seeing this compilation warning turned into an error in automation when building with VS2015u1.
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/39879/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39879/
Attachment #8730453 - Flags: review?(jmuizelaar)
Attachment #8730453 - Flags: review?(jmuizelaar) → review?(jgilbert)
Whiteboard: gfx-noted
This fixes the c4312.
Assignee: nobody → jgilbert
Attachment #8730453 - Attachment is obsolete: true
Attachment #8730453 - Flags: review?(jgilbert)
Attachment #8732476 - Flags: review?(jmuizelaar)
Attachment #8732476 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/96e8d52b4b01
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.