Closed
Bug 1256492
Opened 9 years ago
Closed 9 years ago
gfx/gl/SharedSurfaceEGL.cpp(42): warning C4312: 'reinterpret_cast': conversion from 'GLuint' to 'EGLClientBuffer' of greater size
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: gps, Assigned: jgilbert)
References
Details
(Whiteboard: gfx-noted)
Attachments
(1 file, 1 obsolete file)
|
914 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
We're seeing this compilation warning turned into an error in automation when building with VS2015u1.
|
Reporter | |
Comment 1•9 years ago
|
||
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.
Review commit: https://reviewboard.mozilla.org/r/39879/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39879/
Attachment #8730453 -
Flags: review?(jmuizelaar)
|
||
Updated•9 years ago
|
Attachment #8730453 -
Flags: review?(jmuizelaar) → review?(jgilbert)
|
||
Updated•9 years ago
|
Whiteboard: gfx-noted
|
Assignee | |
Comment 2•9 years ago
|
||
This fixes the c4312.
Assignee: nobody → jgilbert
Attachment #8730453 -
Attachment is obsolete: true
Attachment #8730453 -
Flags: review?(jgilbert)
Attachment #8732476 -
Flags: review?(jmuizelaar)
|
|
||
Updated•9 years ago
|
Attachment #8732476 -
Flags: review?(jmuizelaar) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•