1256496 - hunspell: SEGV near NULL in [@SuggestMgr::leftcommonsubstring]

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Tyson Smith [:tsmith]]

Found in hunspell revision ded5b4c62c37084d216154e02e4d5e6efbd3ccfa

To reproduce:
run ./src/tools/example tests/base_utf.aff tests/base_utf.dic test_case.txt


==48123== ERROR: AddressSanitizer: SEGV on unknown address 0x000000000139 (pc 0x000000479f89 sp 0x7fffe66df870 bp 0x0ffffccdbf18 T0)
AddressSanitizer can not provide additional info.
    #0 0x479f88 in SuggestMgr::leftcommonsubstring(char const*, char const*) /home/user/code/graphite/hunspell/src/hunspell/suggestmgr.cxx:2184
    #1 0x480734 in SuggestMgr::ngsuggest(char**, char*, int, HashMgr**, int) /home/user/code/graphite/hunspell/src/hunspell/suggestmgr.cxx:1361
    #2 0x42d02b in Hunspell::suggest(char***, char const*) /home/user/code/graphite/hunspell/src/hunspell/hunspell.cxx:1057
    #3 0x402ca2 in main /home/user/code/graphite/hunspell/src/tools/example.cxx:92
    #4 0x7fcb9c86cec4 in __libc_start_main /build/eglibc-3GlaMS/eglibc-2.19/csu/libc-start.c:287
    #5 0x403991 in _start (/home/user/Desktop/hunspell/example+0x403991)
SUMMARY: AddressSanitizer: SEGV /home/user/code/graphite/hunspell/src/hunspell/suggestmgr.cxx:2184 SuggestMgr::leftcommonsubstring(char const*, char const*)

Comment 1

[Tyson Smith [:tsmith]]

Attachment: test_case.txt

Comment 2

[Caolan McNamara]

This now passes under asan with github hunspell master

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Should be fixed on trunk by bug 1257902.

Comment 4

[Al Billings [:abillings - ex-MoCo]]

bug 1257902 was fixed in Firefox 47, not 48 or 49. :-)