SAPI speech rate conversion is not accurate

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla48
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
The speech rate that is given is not correctly reflected in the output. For example, setting the uttance rate to 2, gives an increase of 1.43x.
(Assignee)

Comment 1

3 years ago
MozReview-Commit-ID: EuQAqfoxwmo
Attachment #8730490 - Flags: review?(bugs)
(Assignee)

Comment 3

3 years ago
I removed the min/max clipping to allow the underlying engine to deal with rate values outside
the official "supported" range.
Attachment #8730490 - Attachment is obsolete: true
Attachment #8730490 - Flags: review?(bugs)
Attachment #8730840 - Flags: review?(bugs)
(Assignee)

Updated

3 years ago
Blocks: 1254234
Comment on attachment 8730840 [details] [diff] [review]
Normalize speech rate in Windows.

Am I missing something here, or does passing rate 0 really not work?
And since aRate isn't bounded in anyway, how is end results supposed to be [-10,10]
Attachment #8730840 - Flags: review?(bugs) → review-
With 0 case I mean that it is unclear what actually happens if 0 is passed as rate.
(Assignee)

Comment 6

3 years ago
(In reply to Olli Pettay [:smaug] from comment #4)
> Comment on attachment 8730840 [details] [diff] [review]
> Normalize speech rate in Windows.
> 
> Am I missing something here, or does passing rate 0 really not work?

Oops, totally bad stuff happens.

> And since aRate isn't bounded in anyway, how is end results supposed to be
> [-10,10]

According to the msdn docs, values above those bounds are allowed, but the engine does not need to support anything beyond.

But there is a good point here, SpeechSynthesisUtterance.rate should bind the rate to 0.1-10. From a test with Chrome, they do that. I'll open a new bug for that.
(Assignee)

Comment 7

3 years ago
MozReview-Commit-ID: EuQAqfoxwmo
Attachment #8730840 - Attachment is obsolete: true
Attachment #8731350 - Flags: review?(bugs)
Attachment #8731350 - Flags: review?(bugs) → review+

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5cb9d1e18724
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.