Closed
Bug 1256521
Opened 7 years ago
Closed 7 years ago
SAPI speech rate conversion is not accurate
Categories
(Core :: Web Speech, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
()
Details
Attachments
(1 file, 2 obsolete files)
1.74 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
The speech rate that is given is not correctly reflected in the output. For example, setting the uttance rate to 2, gives an increase of 1.43x.
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: EuQAqfoxwmo
Attachment #8730490 -
Flags: review?(bugs)
Assignee | ||
Comment 2•7 years ago
|
||
Benchmark with patch applied: http://eeejay.github.io/webspeechdemos/rates.html?%5B%22urn%3Amoz-tts%3Asapi%3AMicrosoft%20Zira%20Desktop%20-%20English%20(United%20States)%3Fen-US%22%2C%22Microsoft%20Zira%20Desktop%20-%20English%20(United%20States)%22%2C%220.4086112493777999%22%2C%220.4584496816709483%22%2C%220.511432309513426%22%2C%220.5722950362520914%22%2C%220.7170058520394794%22%2C%220.8038582060321191%22%2C%221%22%2C%221.2490870359099209%22%2C%221.4075788751714677%22%2C%221.7665160318485045%22%2C%221.9591885441527446%22%2C%222.176876160169716%22%2C%222.387031113695842%22%5D
Assignee | ||
Comment 3•7 years ago
|
||
I removed the min/max clipping to allow the underlying engine to deal with rate values outside the official "supported" range.
Attachment #8730490 -
Attachment is obsolete: true
Attachment #8730490 -
Flags: review?(bugs)
Attachment #8730840 -
Flags: review?(bugs)
Comment 4•7 years ago
|
||
Comment on attachment 8730840 [details] [diff] [review] Normalize speech rate in Windows. Am I missing something here, or does passing rate 0 really not work? And since aRate isn't bounded in anyway, how is end results supposed to be [-10,10]
Attachment #8730840 -
Flags: review?(bugs) → review-
Comment 5•7 years ago
|
||
With 0 case I mean that it is unclear what actually happens if 0 is passed as rate.
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #4) > Comment on attachment 8730840 [details] [diff] [review] > Normalize speech rate in Windows. > > Am I missing something here, or does passing rate 0 really not work? Oops, totally bad stuff happens. > And since aRate isn't bounded in anyway, how is end results supposed to be > [-10,10] According to the msdn docs, values above those bounds are allowed, but the engine does not need to support anything beyond. But there is a good point here, SpeechSynthesisUtterance.rate should bind the rate to 0.1-10. From a test with Chrome, they do that. I'll open a new bug for that.
Assignee | ||
Comment 7•7 years ago
|
||
MozReview-Commit-ID: EuQAqfoxwmo
Attachment #8730840 -
Attachment is obsolete: true
Attachment #8731350 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8731350 -
Flags: review?(bugs) → review+
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5cb9d1e18724
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•