1256545 - netwerk/srtp/src/crypto/cipher/aes_icm.c(402): warning C4311: 'type cast': pointer truncation from 'unsigned char *' to 'unsigned long'

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Gregory Szorc [:gps]]

This warning gets converted to an error when building on Visual Studio 2015 in automation.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1256545 - Disable C4311 to unblock compilation on VS2015; r?jesup

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists on fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/39975/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39975/

Comment 2

[Byron Campen [:bwc]]

We can probably just cast to uint64_t to fix this.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Actually (uintptr_t) it the right cast.  I'll fix it locally.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: MozReview Request: Bug 1256545: avoid compiler warning for pointer truncation when checking low bits r?gps

Review commit: https://reviewboard.mozilla.org/r/40169/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40169/

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8730528 [details]
MozReview Request: Bug 1256545 - Disable C4311 to unblock compilation on VS2015; r?jesup

https://reviewboard.mozilla.org/r/39975/#review36675

would be fine, but I'd rather fix the warning via my patch

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8730814 [details]
MozReview Request: Bug 1256545: avoid compiler warning for pointer truncation when checking low bits r?gps

https://reviewboard.mozilla.org/r/40169/#review36733

I haven't touch C++ in a very long time. You should find someone who has to review this.

Comment 7

[Byron Campen [:bwc]]

Comment on attachment 8730814 [details]
MozReview Request: Bug 1256545: avoid compiler warning for pointer truncation when checking low bits r?gps

https://reviewboard.mozilla.org/r/40169/#review36737

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8730528 [details]
MozReview Request: Bug 1256545 - Disable C4311 to unblock compilation on VS2015; r?jesup

removing r+ in favor of real fix

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c4df5d33751

Comment 10

[Gregory Szorc [:gps]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=269e13ed36ca

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c4df5d33751