media\webrtc\trunk\webrtc/base/criticalsection.h(59): warning C4312: 'reinterpret_cast': conversion from 'DWORD' to 'HANDLE' of greater size from ipc/glue/BackgroundChildImpl.cpp

RESOLVED DUPLICATE of bug 1257317

Status

()

RESOLVED DUPLICATE of bug 1257317
3 years ago
3 years ago

People

(Reporter: gps, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This warning (from a WebRTC header) gets turned into an error when building with Visual Studio 2015 Update 1 in automation.
(Reporter)

Comment 1

3 years ago
Created attachment 8731410 [details]
MozReview Request: Bug 1256548 - Disable C4312 to unblock compilation on VS2015; r?dvander

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists on fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary. That being said, the underlying problem in the
warning this fixes appears to be in a header from 3rd party WebRTC
code, so our hands might be tied.

Review commit: https://reviewboard.mozilla.org/r/39983/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39983/
Attachment #8731410 - Flags: review?(dvander)
Comment on attachment 8731410 [details]
MozReview Request: Bug 1256548 - Disable C4312 to unblock compilation on VS2015; r?dvander

https://reviewboard.mozilla.org/r/39983/#review37137
Attachment #8731410 - Flags: review?(dvander) → review+
(Reporter)

Comment 3

3 years ago
I'm going to mark this as a dupe since this warning (from 3rd party code) appears in multiple places. jesup already fixed a similar warning elsewhere, so hopefully he can work similar magic for this one.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1257317
You need to log in before you can comment on or make changes to this bug.