1256552 - gfx/2d/RadialGradientEffectD2D1.cpp(162): warning C4838: conversion from 'int' to 'float' requires a narrowing conversion

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Gregory Szorc [:gps]]

This warning is turned into an error when compiling on Visual Studio 2015 Update 1 in automation.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1256552 - Disable C4838 to unblock compilation on VS2015; r?jrmuizel

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists on fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/39989/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39989/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8730548 [details]
MozReview Request: Bug 1256552 - Disable C4838 to unblock compilation on VS2015; r?jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39989/diff/1-2/

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1256552 - Disable C4577 to unblock compilation on VS2015; r?jrmuizel

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/40001/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40001/

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Can you post the compile warnings/errors that these fix so that we have a better chance of fixing them properly?

Comment 5

[Gregory Szorc [:gps]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef4999fe0980 should unmask the warnings. It may not get all of them because build will fail after first warning turned error. But you should be able to pull down that head (hg pull -r 388e18377a7f https://hg.mozilla.org/try) and test your changes on top of that.

Comment 6

[Gregory Szorc [:gps]]

So far we only found 1 warning turned error:

 10:41:40     INFO -  c:/builds/moz2_slave/try-w32-d-00000000000000000000/build/src/gfx/2d/RadialGradientEffectD2D1.cpp(162): error C2220: warning treated as error - no 'object' file generated
 10:41:40     INFO -  Warning: C4838 in c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\src\gfx\2d\RadialGradientEffectD2D1.cpp: conversion from 'int' to 'float' requires a narrowing conversion
 10:41:40     INFO -  c:/builds/moz2_slave/try-w32-d-00000000000000000000/build/src/gfx/2d/RadialGradientEffectD2D1.cpp(162): warning C4838: conversion from 'int' to 'float' requires a narrowing conversion
 10:41:40     INFO -  c:/builds/moz2_slave/try-w32-d-00000000000000000000/build/src/gfx/2d/RadialGradientEffectD2D1.cpp(162): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
10:41:40 INFO - c:/builds/moz2_slave/try-w32-d-00000000000000000000/build/src/config/rules.mk:918: recipe for target 'RadialGradientEffectD2D1.obj' failed

There /might/ be more. But we won't know until this is patched.

Comment 7

[Lee Salzman [:lsalzman]]

Attachment: fix int-to-float conversions in RadialGradientEffectD2D1

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30cc10b99593

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/30cc10b99593

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/abc466f526d9

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/abc466f526d9