1256555 - --disable-webrtc builds fail with dom/media/MediaStreamGraph.cpp:383:5: error: use of undeclared identifier 'shouldAEC'

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Daniel Holbert [:dholbert]]

After I get past bug 1255217's build error, my --disable-webrtc build hits this error:
{
dom/media/MediaStreamGraph.cpp:383:5: error: use of undeclared identifier 'shouldAEC'

     shouldAEC = true;
     ^
}

This variable's declaration & usages are all #ifdef MOZ_WEBRTC, except for this one. Just needs some #ifdeffing.

Comment 1

[Daniel Holbert [:dholbert]]

This line was added here in Bug 1250934:
  http://hg.mozilla.org/mozilla-central/rev/48cb1d9b3039#l1.40

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Here's the fix (just adding an #ifdef).

Comment 3

[Daniel Holbert [:dholbert]]

(With this fix and the band-aid that I posted in bug 1255217, I can build with --disable-webrtc again.)

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8730554 [details] [diff] [review]
fix v1

Review of attachment 8730554 [details] [diff] [review]:
-----------------------------------------------------------------

Was just going to fix this myself; thanks

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/463b44507a7f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/463b44507a7f