Closed Bug 1256560 Opened 4 years ago Closed 4 years ago

Implement AnimationEffectTiming WebIDL

Categories

(Core :: DOM: Animation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

()

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
The idea here is to make all the required changes to AnimationEffectTiming.webidl at once to save having to request DOM peer review for each attribute (and also so that we can fill in the implementation of each of the corresponding methods during our Gecko inside hands-on patch writing event without having to wait for additional review.)
Assignee: nobody → daisuke
Hi Brian,
I'll ask to review to Olli after your r+.
Attachment #8732077 - Flags: review?(bbirtles)
Attachment #8732078 - Flags: review?(bbirtles)
Attachment #8732077 - Flags: review?(bbirtles) → review+
Comment on attachment 8732078 [details] [diff] [review]
Part 2: Implement empty setter for new WebIDL

Review of attachment 8732078 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, but I think part 1 doesn't build without part 2, right?

We should make each patch able to build and pass all tests. Please merge with part 1 and then request review for the WebIDL changes from a DOM peer.
Attachment #8732078 - Flags: review?(bbirtles) → review+
Merged patch 1 and 2.
Attachment #8732077 - Attachment is obsolete: true
Attachment #8732078 - Attachment is obsolete: true
Comment on attachment 8733156 [details] [diff] [review]
Part 1: Implement AnimationEffectTiming WebIDL

Hi Olli, thank you always!
Couldn't you review dom/webidl/AnimationEffectTiming.webidl ?
Attachment #8733156 - Flags: review?(bugs)
Comment on attachment 8733156 [details] [diff] [review]
Part 1: Implement AnimationEffectTiming WebIDL

r+ for the .webidl
Attachment #8733156 - Flags: review?(bugs) → review+
Attachment #8733156 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c2da2b90880f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.