1256614 - Replace or remove check target in mozglue/linker/tests/Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

This makefile has a check target that runs a little C++ test:
https://hg.mozilla.org/mozilla-central/file/5e14887312d4523ab59c3f6c6c94a679cf42b496/mozglue/linker/tests/Makefile.in

I guess it can't be a CPP_UNIT_TEST because it depends on a file from the srcdir? We could port this to a simple PYTHON_UNIT_TEST that calls the binary, but I also note that this is only ever run if MOZ_LINKER is set, which is only ever set on Android, and Android builds don't run `make check` so this test is not actually running anywhere currently.

Comment 1

[Mike Hommey [:glandium]]

Except you can build locally (or on try) on linux with MOZ_LINKER=1.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1256614 - replace mozglue/linker/tests/Makefile.in with a PYTHON_UNIT_TEST. r?glandium

Review commit: https://reviewboard.mozilla.org/r/40085/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40085/

Comment 3

[(not currently active) Ted Mielczarek]

I did a local build with MOZ_LINKER=1, and the test runs fine there:
```
luser@eye7:/build/mozilla-central$ ./mach python-test mozglue/linker/tests/
 0:01.04 /build/debug-mozilla-central/_virtualenv/bin/python /build/mozilla-central/mozglue/linker/tests/run_test_zip.py
 0:01.10 TEST-PASS | TestZip | test.zip could be accessed fully
 0:01.10 TEST-PASS | TestZip | no_central_dir.zip could be accessed in order
 0:01.10 TEST-PASS | /build/mozilla-central/mozglue/linker/tests/run_test_zip.py | TestZip.test_zip
```

Comment 4

[Michael Shal [:mshal]]

I tried (unsuccessfully) to make this a CppUnitTest in bug 1253117.

Comment 5

[Michael Shal [:mshal]]

I'm not sure if my issue shows up in reviewboard, but FYI the "if CONFIG['MOZ_LINKER']" line can go away since mozglue/moz.build only recurses into linker inside the same if CONFIG['MOZ_LINKER'] check.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8730685 [details]
MozReview Request: bug 1256614 - replace mozglue/linker/tests/Makefile.in with a PYTHON_UNIT_TEST. r?glandium

https://reviewboard.mozilla.org/r/40085/#review36821

Fair enough.

::: mozglue/linker/tests/moz.build:18
(Diff revision 1)
>  USE_LIBS += [
>      'linker',
>  ]
>  DISABLE_STL_WRAPPING = True
>  
>  if CONFIG['MOZ_LINKER']:

This condition comes, iirc, from when this test was in mozglue/tests. You can remove it while you're in the vicinity.

Comment 8

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/652d09c3a912fd9af0aca7d944a5c8a825f56cf5
bug 1256614 - replace mozglue/linker/tests/Makefile.in with a PYTHON_UNIT_TEST. r=glandium

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/652d09c3a912