Closed Bug 1256625 Opened 8 years ago Closed 8 years ago

Proxy callback functions from the child process in UITour head.js

Categories

(Firefox :: Tours, defect)

44 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We proxy the function calls, but any callback parameters, such as to getConfiguration, don't get dealt with, and the result is that things Don't Work in e10s.

This is fixable. :-)
Blocks: 1256746
Comment on attachment 8730666 [details]
MozReview Request: Bug 1256625 - enable function parameters to gContentAPI wrappers to fix UITour tests in e10s mode, r?MattN

https://reviewboard.mozilla.org/r/40077/#review37687

This is a lot of non-trivial code to implement this feature so before this patch I was leaning towards switching the tests which used callbacks to their equiavalent promise-based ContentTask helper instead. I also didn't really see the Proxy hack as a long-term solution (e.g. for new tests) but was a quick way to avoid rewriting existing tests. Since you already did the work I guess this is fine but if there are easy cases in the future where you can use an existing promise helper with ContentTask then please prefer that.
Attachment #8730666 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/a6dca9d0ecdd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.