1256650 - Autophone - deal with removal of --bootstrap option in remotereftest.py

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

The reftest based unit tests no longer work on trunk due to the removal of the --bootstrap option.

Two options I can think of off hand are:

1. check if the branch >= 48 and date >= the checkin date then don't use --bootstrap.
2. actually run remotereftest.py --help and look in the output for --bootstrap.

Kind of looking at #2 as the solution.

ahal: please ping me when removing command line arguments in the reftest/mochitest test runners. thanks.

Comment 1

[Andrew Halberstadt [:ahal]]

Sorry bc! I did a dxr of --bootstrap and didn't see it being used anywhere, so thought it was dead code. The removal of --bootstrap has been uplifted all the way to beta already though.. so if you don't test release, then you may not need the check.

Comment 2

[Andrew Halberstadt [:ahal]]

Actually, even before my patch --bootstrap was actually not being used anywhere. So you can just remove it from your configs entirely and it should just work everywhere.

E.g:
http://mxr.mozilla.org/mozilla-release/search?string=bootstrap&find=layout%2Ftools%2Freftest&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozilla-release

See how there's dest='bootstrap' in the argparser, but then options.bootstrap isn't referenced anywhere.

Comment 3

[Bob Clary [:bc] (inactive)]

ahal, thanks! The usage appears to have been removed in Bug 1181516 on 2015-09-17 15:03:20 PDT so, lets just call it a day and remove it altogether.

Comment 4

[Bob Clary [:bc] (inactive)]

Attachment: bug-1256650-v1.patch

Comment 5

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8730746 [details] [diff] [review]
bug-1256650-v1.patch

Review of attachment 8730746 [details] [diff] [review]:
-----------------------------------------------------------------

yay for code removal!

Comment 6

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/d00e241593a64485d70ac4660a057ef2db9b39a2

Comment 7

[Bob Clary [:bc] (inactive)]

deployed 2016-03-15 ~22:46

Comment 8

[Bob Clary [:bc] (inactive)]

doh, deployed 2016-03-16 ~22:46