Closed
Bug 1256690
Opened 8 years ago
Closed 8 years ago
[DevTools][Net Monitor] requests-menu-empty-notice does not display after pushing the clear button
Categories
(DevTools :: Netmonitor, defect, P2)
DevTools
Netmonitor
Tracking
(firefox45 affected, firefox46 affected, firefox47 affected, firefox48 fixed, firefox-esr38 affected, firefox-esr45 affected)
RESOLVED
FIXED
Firefox 48
People
(Reporter: magicp.jp, Assigned: Honza)
References
Details
Attachments
(2 files, 1 obsolete file)
|
114.83 KB,
image/png
|
Details | |
|
3.14 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
netmonitor-after-clear-network-table.png
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 Build ID: 20160314030215 Steps to reproduce: 1. Start Nightly 2. Go to any sites (e.g. https://www.mozilla.org/en-US/firefox/central/) 3. Open DevTools > Net Monitor 4. Click Reload button 5. Click Clear button Actual results: requests-menu-empty-notice does not display after pushing the clear button. Expected results: requests-menu-empty-notice is displayed after pushing the clear button.
Has STR: --- → yes
status-firefox45:
--- → affected
status-firefox46:
--- → affected
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox-esr38:
--- → affected
status-firefox-esr45:
--- → affected
Component: Untriaged → Developer Tools: Netmonitor
OS: Unspecified → All
Hardware: Unspecified → All
|
Assignee | |
Comment 1•8 years ago
|
||
Thanks for the report. I can reproduce this on my machine using STR from comment #0. Honza
Priority: -- → P2
|
|
Assignee | |
Comment 2•8 years ago
|
||
Victor, quick patch for the issue + existing test extended. (part of the net-panel-learning process :) Honza
|
|
Assignee | |
Comment 3•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e54c1120b53d Honza
|
|
Assignee | |
Comment 4•8 years ago
|
||
Using proper commit message. Honza
Attachment #8731221 -
Attachment is obsolete: true
Attachment #8731221 -
Flags: review?(vporof)
Attachment #8731226 -
Flags: review?(vporof)
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8731226 [details] [diff] [review] bug1256690.patch Review of attachment 8731226 [details] [diff] [review]: ----------------------------------------------------------------- very nice
Attachment #8731226 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/eca3a186bb79
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•