Closed
Bug 1256776
Opened 10 years ago
Closed 10 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_bug_871156_ctrlw_close_tab.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: linclark, Unassigned, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up
Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards
Then you can see the issues that need to be fixed by running
> eslint --no-ignore devtools/client/webconsole/test/browser_bug_871156_ctrlw_close_tab.js
| Reporter | ||
Updated•10 years ago
|
Whiteboard: [btpp-backlog]
Comment 1•10 years ago
|
||
I'll take this one.
Comment 2•10 years ago
|
||
Hmm, running eslint says that there aren't any eslint issues here.
```
./mach eslint --no-ignore devtools/client/webconsole/test/browser_bug_871156_ctrlw_close_tab.js
0:00.09 Running /home/wldcordeiro/.nvm/versions/node/v5.11.0/bin/eslint
0:00.09 /home/wldcordeiro/.nvm/versions/node/v5.11.0/bin/eslint --plugin html --ext [.js,.jsm,.jsx,.xml,.html] --no-ignore devtools/client/webconsole/test/browser_bug_871156_ctrlw_close_tab.js
0:01.25 Finished eslint. No errors encountered.
```
Flags: needinfo?(jlaster)
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(jlaster)
Resolution: --- → WORKSFORME
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•