1256779 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_cached_messages.js

Status: RESOLVED WONTFIX

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_cached_messages.js

Comment 1

[simplyblue24]

Attachment: 1256779.patch

Hi, please review my patch

Comment 2

[Jason Laster [:jlast]]

Hi simplyblue, linclark would be a better reviewer.

Comment 3

[Lin Clark [:linclark]]

Comment on attachment 8739375 [details] [diff] [review]
1256779.patch

Review of attachment 8739375 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Feel free to add checkin-needed

Comment 4

[Brian Grinstead [:bgrins]]

Closing unassigned webconsole test eslint bugs.  These tests will either be copied over and refactored for the new console frontend or removed and replaced with unit tests, so no sense in spending time fixing lint errors.  See bug 1308219.

Filter on NOVEMBERSEVENTH