1256780 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_addonsdk_loader_exception.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_addonsdk_loader_exception.js

Comment 1

[Jaideep Bhoosreddy [:jbhoosreddy]]

Attachment: 1256780.patch

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8755621 [details] [diff] [review]
1256780.patch

Review of attachment 8755621 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  Please update the commit message to end with ;r=bgrins and also get rid of the leading [ESLint]

Comment 3

[Jaideep Bhoosreddy [:jbhoosreddy]]

Attachment: 1256780.patch [1.0]

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=abc0fbca934d

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fad6d48e70f1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fad6d48e70f1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dcbb232b05bf