1256785 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_dead_objects.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_dead_objects.js

Comment 1

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256785-ESLint.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f04f8c7322b1

Comment 2

[Jason Laster [:jlast]]

Comment on attachment 8750021 [details] [diff] [review]
0001-Bug-1256785-ESLint.patch

Review of attachment 8750021 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/595726ab8d29

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/595726ab8d29

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/28efb86c3f0a