Closed Bug 1256789 Opened 8 years ago Closed 8 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_iframe_messages.js

Categories

(DevTools :: Console, defect, P3)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: linclark, Assigned: jryans, Mentored)

References

Details

(Whiteboard: [btpp-backlog][fixed-by-bug-1271084])

Attachments

(1 file)

0001-Bug-1256789-ESLint.patch
1.05 KB, patch
jlast
: review+
Details | Diff | Splinter Review 
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_iframe_messages.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Assignee: nobody → me
Status: NEW → ASSIGNED
Comment on attachment 8750020 [details] [diff] [review]
0001-Bug-1256789-ESLint.patch

Review of attachment 8750020 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8750020 - Flags: review?(jlaster) → review+
This was fixed by https://hg.mozilla.org/integration/fx-team/rev/c4b1eb619c41
Keywords: checkin-needed
Whiteboard: [btpp-backlog] → [btpp-backlog][fixed-by-bug-1271084]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee: me → jryans
Depends on: 1271084
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: