[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_nsiconsolemessage.js

RESOLVED FIXED in Firefox 48

Status

defect
P3
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: linclark, Assigned: mkohler, Mentored)

Tracking

unspecified
Firefox 49
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment)

Reporter

Description

3 years ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_nsiconsolemessage.js
Reporter

Updated

3 years ago
Blocks: 1256948
Priority: -- → P3
Reporter

Updated

3 years ago
Whiteboard: [btpp-backlog]
Assignee

Updated

3 years ago
Assignee: nobody → me
Assignee

Comment 1

3 years ago
Attachment #8748406 - Flags: review?(lclark)
Assignee

Updated

3 years ago
Status: NEW → ASSIGNED
Reporter

Comment 3

3 years ago
Comment on attachment 8748406 [details] [diff] [review]
0001-Bug-1256792-ESLint.patch

Review of attachment 8748406 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8748406 - Flags: review?(lclark) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7740286bd255
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.