The default bug view has changed. See this FAQ.

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_server_logging.js

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: linclark, Assigned: a.l.e, Mentored)

Tracking

unspecified
Firefox 49
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_server_logging.js
(Reporter)

Updated

a year ago
Blocks: 1256948
Priority: -- → P3
(Reporter)

Updated

a year ago
Whiteboard: [btpp-backlog]
(Assignee)

Comment 1

11 months ago
Created attachment 8747443 [details] [diff] [review]
0001-Bug-1256795-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

more greetings from the firefox hackaton in zurich
Attachment #8747443 - Flags: review?(lclark)

Updated

11 months ago
Assignee: nobody → ale.comp_06
https://treeherder.mozilla.org/#/jobs?repo=try&revision=455181a695f1
(Reporter)

Comment 3

11 months ago
Comment on attachment 8747443 [details] [diff] [review]
0001-Bug-1256795-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747443 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Could you fix up the commit message for this one before we commit?
Attachment #8747443 - Flags: review?(lclark) → review+
Created attachment 8749350 [details] [diff] [review]
updated_commitmessage_reviewer_added
Attachment #8747443 - Attachment is obsolete: true
Attachment #8749350 - Flags: review+
I felt free to update the commit message for you since this includes a fix that will be useful for a whole lot of other ESLint bugs :)

Thanks for the patch!
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 6

11 months ago
https://hg.mozilla.org/integration/fx-team/rev/779aadcbc188
Keywords: checkin-needed

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/779aadcbc188
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Comment 8

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/c443cfd5fb7c
status-firefox48: --- → fixed
You need to log in before you can comment on or make changes to this bug.