Closed Bug 1256795 Opened 4 years ago Closed 4 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_server_logging.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: ale.comp_06, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file, 1 obsolete file)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_server_logging.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
more greetings from the firefox hackaton in zurich
Attachment #8747443 - Flags: review?(lclark)
Assignee: nobody → ale.comp_06
Comment on attachment 8747443 [details] [diff] [review]
0001-Bug-1256795-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747443 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Could you fix up the commit message for this one before we commit?
Attachment #8747443 - Flags: review?(lclark) → review+
Attachment #8747443 - Attachment is obsolete: true
Attachment #8749350 - Flags: review+
I felt free to update the commit message for you since this includes a fix that will be useful for a whole lot of other ESLint bugs :)

Thanks for the patch!
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/779aadcbc188
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.