Closed
Bug 1256795
Opened 8 years ago
Closed 8 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_server_logging.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: linclark, Assigned: ale.comp_06, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file, 1 obsolete file)
1.81 KB,
patch
|
mkohler
:
review+
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/browser_console_server_logging.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
more greetings from the firefox hackaton in zurich
Attachment #8747443 -
Flags: review?(lclark)
Updated•8 years ago
|
Assignee: nobody → ale.comp_06
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8747443 [details] [diff] [review] 0001-Bug-1256795-ESLint-Fix-ESLint-issues-in-devtools-cli.patch Review of attachment 8747443 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! Could you fix up the commit message for this one before we commit?
Attachment #8747443 -
Flags: review?(lclark) → review+
Comment 4•8 years ago
|
||
Attachment #8747443 -
Attachment is obsolete: true
Attachment #8749350 -
Flags: review+
Comment 5•8 years ago
|
||
I felt free to update the commit message for you since this includes a fix that will be useful for a whole lot of other ESLint bugs :) Thanks for the patch!
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/779aadcbc188
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/c443cfd5fb7c
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•