[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_variables_view_filter.js

RESOLVED FIXED in Firefox 48

Status

defect
P3
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: linclark, Assigned: mkohler, Mentored)

Tracking

unspecified
Firefox 49
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

3 years ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_variables_view_filter.js
Reporter

Updated

3 years ago
Blocks: 1256948
Priority: -- → P3
Reporter

Updated

3 years ago
Whiteboard: [btpp-backlog]

Comment 1

3 years ago
Hi can you please provide some steps to solve this bug..?


Thank you
Flags: needinfo?(lclark)
Reporter

Comment 2

3 years ago
The steps are provided in the issue description.
Flags: needinfo?(lclark)
Assignee

Updated

3 years ago
Assignee: nobody → me
Assignee

Comment 3

3 years ago
Posted patch 0001-Bug-1256798-ESLint.patch (obsolete) — Splinter Review
Attachment #8748407 - Flags: review?(lclark)
Reporter

Comment 5

3 years ago
Comment on attachment 8748407 [details] [diff] [review]
0001-Bug-1256798-ESLint.patch

Review of attachment 8748407 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_console_variables_view_filter.js
@@ +37,4 @@
>    let variablesView = view._variablesView;
>    let searchbox = variablesView._searchboxNode;
>  
> +  assertAttrs(view, "foo,__proto__", "To start with, we just see the top" +

Rather than splitting these, let's bump them down to the next line and edit to see if we can get them under the char limit.
Attachment #8748407 - Flags: review?(lclark)
Assignee

Comment 6

3 years ago
Attachment #8748407 - Attachment is obsolete: true
Attachment #8749972 - Flags: review?(jlaster)
Comment on attachment 8749972 [details] [diff] [review]
0001-Bug-1256798-ESLint.patch

Review of attachment 8749972 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8749972 - Flags: review?(jlaster) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/11f540380325
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.