1256798 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_variables_view_filter.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_variables_view_filter.js

Comment 1

[agore1]

Hi can you please provide some steps to solve this bug..?


Thank you

Comment 2

[Lin Clark [:linclark]]

The steps are provided in the issue description.

Comment 3

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256798-ESLint.patch

Comment 4

[Michael Kohler [:mkohler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=565df31b8623

Comment 5

[Lin Clark [:linclark]]

Comment on attachment 8748407 [details] [diff] [review]
0001-Bug-1256798-ESLint.patch

Review of attachment 8748407 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_console_variables_view_filter.js
@@ +37,4 @@
>    let variablesView = view._variablesView;
>    let searchbox = variablesView._searchboxNode;
>  
> +  assertAttrs(view, "foo,__proto__", "To start with, we just see the top" +

Rather than splitting these, let's bump them down to the next line and edit to see if we can get them under the char limit.

Comment 6

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256798-ESLint.patch

Comment 7

[Michael Kohler [:mkohler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcac05bf4efb

Comment 8

[Jason Laster [:jlast]]

Comment on attachment 8749972 [details] [diff] [review]
0001-Bug-1256798-ESLint.patch

Review of attachment 8749972 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/11f540380325

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11f540380325

Comment 11

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9e856f294fa1