Closed Bug 1256798 Opened 4 years ago Closed 4 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_variables_view_filter.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: mkohler, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file, 1 obsolete file)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_console_variables_view_filter.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Hi can you please provide some steps to solve this bug..?


Thank you
Flags: needinfo?(lclark)
The steps are provided in the issue description.
Flags: needinfo?(lclark)
Assignee: nobody → me
Attached patch 0001-Bug-1256798-ESLint.patch (obsolete) — Splinter Review
Attachment #8748407 - Flags: review?(lclark)
Comment on attachment 8748407 [details] [diff] [review]
0001-Bug-1256798-ESLint.patch

Review of attachment 8748407 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_console_variables_view_filter.js
@@ +37,4 @@
>    let variablesView = view._variablesView;
>    let searchbox = variablesView._searchboxNode;
>  
> +  assertAttrs(view, "foo,__proto__", "To start with, we just see the top" +

Rather than splitting these, let's bump them down to the next line and edit to see if we can get them under the char limit.
Attachment #8748407 - Flags: review?(lclark)
Attachment #8748407 - Attachment is obsolete: true
Attachment #8749972 - Flags: review?(jlaster)
Comment on attachment 8749972 [details] [diff] [review]
0001-Bug-1256798-ESLint.patch

Review of attachment 8749972 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8749972 - Flags: review?(jlaster) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/11f540380325
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.