Closed
Bug 1256798
Opened 8 years ago
Closed 8 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_console_variables_view_filter.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: linclark, Assigned: mkohler, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file, 1 obsolete file)
2.54 KB,
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/browser_console_variables_view_filter.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
Hi can you please provide some steps to solve this bug..? Thank you
Flags: needinfo?(lclark)
Reporter | ||
Comment 2•8 years ago
|
||
The steps are provided in the issue description.
Flags: needinfo?(lclark)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → me
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8748407 -
Flags: review?(lclark)
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=565df31b8623
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8748407 [details] [diff] [review] 0001-Bug-1256798-ESLint.patch Review of attachment 8748407 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/webconsole/test/browser_console_variables_view_filter.js @@ +37,4 @@ > let variablesView = view._variablesView; > let searchbox = variablesView._searchboxNode; > > + assertAttrs(view, "foo,__proto__", "To start with, we just see the top" + Rather than splitting these, let's bump them down to the next line and edit to see if we can get them under the char limit.
Attachment #8748407 -
Flags: review?(lclark)
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8748407 -
Attachment is obsolete: true
Attachment #8749972 -
Flags: review?(jlaster)
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcac05bf4efb
Comment 8•8 years ago
|
||
Comment on attachment 8749972 [details] [diff] [review] 0001-Bug-1256798-ESLint.patch Review of attachment 8749972 [details] [diff] [review]: ----------------------------------------------------------------- lgtm!
Attachment #8749972 -
Flags: review?(jlaster) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/11f540380325
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/9e856f294fa1
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•