Closed Bug 1256810 Opened 4 years ago Closed 4 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_repeated_messages_accuracy.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: linclark, Assigned: ab506032, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file, 5 obsolete files)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_repeated_messages_accuracy.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Attached patch 1256810.patch (obsolete) — Splinter Review
Attachment #8747433 - Flags: review?(lclark)
Assignee: nobody → ab506032
Attached patch 1256810.patch (obsolete) — Splinter Review
Commit message contained a typo in the previous patch.
Attachment #8747433 - Attachment is obsolete: true
Attachment #8747433 - Flags: review?(lclark)
Attachment #8747439 - Flags: review?(lclark)
Comment on attachment 8747439 [details] [diff] [review]
1256810.patch

Review of attachment 8747439 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for the patch!

Before we commit it, would you mind adding the reviewer to the commit message? You can just add r=linclark
Attachment #8747439 - Flags: review?(lclark) → review+
Attached patch 1256810.patch (obsolete) — Splinter Review
(Just added ". r=linclark" to patch description as requested in comment 4. R+ carried over.)
Attachment #8747439 - Attachment is obsolete: true
Attachment #8761285 - Flags: review+
Attached patch 1256810.patch (obsolete) — Splinter Review
(Also added a trailing new line to un-corrupt the patch, and pushed it to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3511572d5ec6. R+ carried over.)
Attachment #8761561 - Flags: review+
Attachment #8761285 - Attachment is obsolete: true
Attachment #8761561 - Attachment is obsolete: true
Attached patch 1256810.patchSplinter Review
(Hopefully getting `git bz attach` right this time.)
Attachment #8761564 - Flags: review+
Attachment #8761563 - Attachment is obsolete: true
Please check this patch in. The few intermittent failures look unrelated: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3511572d5ec6
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/d4a0d8bebf11
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_repeated_messages_accuracy.js. r=linclark
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d4a0d8bebf11
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.