[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_repeated_messages_accuracy.js

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: linclark, Assigned: Fabien, Mentored)

Tracking

unspecified
Firefox 50
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed, firefox50 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment, 5 obsolete attachments)

(Reporter)

Description

a year ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_repeated_messages_accuracy.js
(Reporter)

Updated

a year ago
Blocks: 1256948
Priority: -- → P3
(Reporter)

Updated

a year ago
Whiteboard: [btpp-backlog]
(Assignee)

Comment 1

a year ago
Created attachment 8747433 [details] [diff] [review]
1256810.patch
Attachment #8747433 - Flags: review?(lclark)
Assignee: nobody → ab506032
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0263376aaf2
(Assignee)

Comment 3

a year ago
Created attachment 8747439 [details] [diff] [review]
1256810.patch

Commit message contained a typo in the previous patch.
Attachment #8747433 - Attachment is obsolete: true
Attachment #8747433 - Flags: review?(lclark)
Attachment #8747439 - Flags: review?(lclark)
(Reporter)

Comment 4

a year ago
Comment on attachment 8747439 [details] [diff] [review]
1256810.patch

Review of attachment 8747439 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for the patch!

Before we commit it, would you mind adding the reviewer to the commit message? You can just add r=linclark
Attachment #8747439 - Flags: review?(lclark) → review+
Created attachment 8761285 [details] [diff] [review]
1256810.patch

(Just added ". r=linclark" to patch description as requested in comment 4. R+ carried over.)
Attachment #8747439 - Attachment is obsolete: true
Attachment #8761285 - Flags: review+
Created attachment 8761561 [details] [diff] [review]
1256810.patch

(Also added a trailing new line to un-corrupt the patch, and pushed it to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3511572d5ec6. R+ carried over.)
Attachment #8761561 - Flags: review+

Updated

a year ago
Attachment #8761285 - Attachment is obsolete: true
Comment hidden (obsolete)

Updated

a year ago
Attachment #8761561 - Attachment is obsolete: true
Created attachment 8761564 [details] [diff] [review]
1256810.patch

(Hopefully getting `git bz attach` right this time.)
Attachment #8761564 - Flags: review+

Updated

a year ago
Attachment #8761563 - Attachment is obsolete: true
Please check this patch in. The few intermittent failures look unrelated: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3511572d5ec6
Keywords: checkin-needed

Comment 10

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/d4a0d8bebf11
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_repeated_messages_accuracy.js. r=linclark
Keywords: checkin-needed

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d4a0d8bebf11
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Comment 12

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/10c5ec23f0a9
status-firefox49: --- → fixed

Comment 13

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/6afbed5e8e6c
status-firefox48: --- → fixed
You need to log in before you can comment on or make changes to this bug.