[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_warn_user_about_replaced_api.js

RESOLVED FIXED in Firefox 48

Status

P3
normal
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: linclark, Assigned: moby, Mentored)

Tracking

unspecified
Firefox 49
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_warn_user_about_replaced_api.js
(Reporter)

Updated

3 years ago
Blocks: 1256948
Priority: -- → P3
(Reporter)

Updated

3 years ago
Whiteboard: [btpp-backlog]
Blocks: 1236174
(Assignee)

Comment 1

2 years ago
Created attachment 8756572 [details] [diff] [review]
fix-cpow.patch
Attachment #8756572 - Flags: review?(bgrinstead)
(Assignee)

Updated

2 years ago
Assignee: nobody → mvonbriesen
Comment on attachment 8756572 [details] [diff] [review]
fix-cpow.patch

Review of attachment 8756572 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, try push:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e81168bbcff
Attachment #8756572 - Flags: review?(bgrinstead) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f0ad74c19f64
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Comment 6

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/21a7e88e2cc8
status-firefox48: --- → fixed

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.