Closed
Bug 1256812
Opened 8 years ago
Closed 8 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_warn_user_about_replaced_api.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: linclark, Assigned: moby, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file)
2.17 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/browser_warn_user_about_replaced_api.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8756572 -
Flags: review?(bgrinstead)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mvonbriesen
Comment 2•8 years ago
|
||
Comment on attachment 8756572 [details] [diff] [review] fix-cpow.patch Review of attachment 8756572 [details] [diff] [review]: ----------------------------------------------------------------- Works for me, try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e81168bbcff
Attachment #8756572 -
Flags: review?(bgrinstead) → review+
Comment 3•8 years ago
|
||
Here's actual try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f126b3243998
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f0ad74c19f64
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 6•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/21a7e88e2cc8
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•