1256812 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_warn_user_about_replaced_api.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_warn_user_about_replaced_api.js

Comment 1

[Maximillian von Briesen [:moby]]

Attachment: fix-cpow.patch

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8756572 [details] [diff] [review]
fix-cpow.patch

Review of attachment 8756572 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, try push:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e81168bbcff

Comment 3

[Brian Grinstead [:bgrins]]

Here's actual try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f126b3243998

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f0ad74c19f64

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f0ad74c19f64

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/21a7e88e2cc8