Closed Bug 1256819 Opened 7 years ago Closed 7 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_1010953_cspro.js

Categories

(DevTools :: Console, defect, P3)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(firefox48 fixed, firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: moby, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file)

eslint-fix.patch
1.11 KB, patch
bgrins
: review+
Details | Diff | Splinter Review 
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_1010953_cspro.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Attached patch eslint-fix.patch — — Splinter Review 

        Attachment #8756115 -
        Flags: review?(bgrinstead)

    
    

    
  
Comment on attachment 8756115 [details] [diff] [review]
eslint-fix.patch

Review of attachment 8756115 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.  Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b2b3ba0385b

        Attachment #8756115 -
        Flags: review?(bgrinstead) → review+
Assignee: nobody → mvonbriesen
Status: NEW → ASSIGNED

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3c5ce08d5baa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox49:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
No longer depends on: 1276349

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.