Closed Bug 1256830 Opened 4 years ago Closed 3 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_587617_output_copy.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: moby, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file, 2 obsolete files)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_587617_output_copy.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Blocks: 1238824
Assignee: nobody → mvonbriesen
Attachment #8756589 - Flags: review?(bgrinstead)
Comment on attachment 8756589 [details] [diff] [review]
webconsole_bug_587617_output_copy-eslint.patch

Review of attachment 8756589 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_webconsole_bug_587617_output_copy.js
@@ +36,5 @@
>    is(controller.isCommandEnabled("cmd_copy"), false, "cmd_copy is disabled");
>  
> +  let browser = gBrowser.selectedBrowser;
> +  let taskStr = "() => content.console.log('Hello world! bug587617')";
> +  ContentTask.spawn(browser, null, taskStr);

Nit: can you reformat this to not have the variables and instead break the call up over two lines?  Something like:


    ContentTask.spawn(gBrowser.selectedBrowser, null,
      "() => content.console.log('Hello world! bug587617')"
Attachment #8756589 - Flags: review?(bgrinstead) → review+
Attachment #8756589 - Attachment is obsolete: true
Attachment #8757035 - Attachment is obsolete: true
Attachment #8757041 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/db599457058b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.