1256830 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_587617_output_copy.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_587617_output_copy.js

Comment 1

[Maximillian von Briesen [:moby]]

Attachment: webconsole_bug_587617_output_copy-eslint.patch

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8756589 [details] [diff] [review]
webconsole_bug_587617_output_copy-eslint.patch

Review of attachment 8756589 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_webconsole_bug_587617_output_copy.js
@@ +36,5 @@
>    is(controller.isCommandEnabled("cmd_copy"), false, "cmd_copy is disabled");
>  
> +  let browser = gBrowser.selectedBrowser;
> +  let taskStr = "() => content.console.log('Hello world! bug587617')";
> +  ContentTask.spawn(browser, null, taskStr);

Nit: can you reformat this to not have the variables and instead break the call up over two lines?  Something like:


    ContentTask.spawn(gBrowser.selectedBrowser, null,
      "() => content.console.log('Hello world! bug587617')"

Comment 3

[Maximillian von Briesen [:moby]]

Attachment: browser_webconsole_bug_587617_output_copy.patch

Comment 4

[Maximillian von Briesen [:moby]]

Attachment: browser_webconsole_bug_587617_output_copy.patch

Comment 5

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2c682a1d653

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/db599457058b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db599457058b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/433520b687b7