1256846 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_601352_scroll.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_601352_scroll.js

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1256846 - Fix ESLint issues in browser_webconsole_bug_601352_scroll.js;r=tromey

Review commit: https://reviewboard.mozilla.org/r/50843/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50843/

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1256846 - Switch to add_task for browser_webconsole_bug_601352_scroll.js;r=tromey

Review commit: https://reviewboard.mozilla.org/r/50845/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50845/

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8749312 [details]
MozReview Request: Bug 1256846 - Fix ESLint issues in browser_webconsole_bug_601352_scroll.js;r=tromey

https://reviewboard.mozilla.org/r/50843/#review47541

Thank you for doing this.  It looks great.

Comment 5

[Tom Tromey :tromey]

Comment on attachment 8749313 [details]
MozReview Request: Bug 1256846 - Switch to add_task for browser_webconsole_bug_601352_scroll.js;r=tromey

https://reviewboard.mozilla.org/r/50845/#review47543

Thank you.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4ad31cb68cfa
https://hg.mozilla.org/integration/fx-team/rev/7189e5f1105b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ad31cb68cfa
https://hg.mozilla.org/mozilla-central/rev/7189e5f1105b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d81a217b8759
https://hg.mozilla.org/releases/mozilla-aurora/rev/61411310ed8a