Closed Bug 1256846 Opened 4 years ago Closed 4 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_601352_scroll.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: bgrins, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(2 files)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_601352_scroll.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Duplicate of this bug: 1262558
Comment on attachment 8749312 [details]
MozReview Request: Bug 1256846 - Fix ESLint issues in browser_webconsole_bug_601352_scroll.js;r=tromey

https://reviewboard.mozilla.org/r/50843/#review47541

Thank you for doing this.  It looks great.
Attachment #8749312 - Flags: review?(ttromey) → review+
Attachment #8749313 - Flags: review?(ttromey) → review+
Comment on attachment 8749313 [details]
MozReview Request: Bug 1256846 - Switch to add_task for browser_webconsole_bug_601352_scroll.js;r=tromey

https://reviewboard.mozilla.org/r/50845/#review47543

Thank you.
https://hg.mozilla.org/mozilla-central/rev/4ad31cb68cfa
https://hg.mozilla.org/mozilla-central/rev/7189e5f1105b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.