Closed
Bug 1256846
Opened 8 years ago
Closed 8 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_601352_scroll.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: linclark, Assigned: bgrins, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(2 files)
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_601352_scroll.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50843/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50843/
Attachment #8749312 -
Flags: review?(ttromey)
Attachment #8749313 -
Flags: review?(ttromey)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50845/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50845/
Comment 4•8 years ago
|
||
Comment on attachment 8749312 [details] MozReview Request: Bug 1256846 - Fix ESLint issues in browser_webconsole_bug_601352_scroll.js;r=tromey https://reviewboard.mozilla.org/r/50843/#review47541 Thank you for doing this. It looks great.
Attachment #8749312 -
Flags: review?(ttromey) → review+
Updated•8 years ago
|
Attachment #8749313 -
Flags: review?(ttromey) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8749313 [details] MozReview Request: Bug 1256846 - Switch to add_task for browser_webconsole_bug_601352_scroll.js;r=tromey https://reviewboard.mozilla.org/r/50845/#review47543 Thank you.
https://hg.mozilla.org/integration/fx-team/rev/4ad31cb68cfa https://hg.mozilla.org/integration/fx-team/rev/7189e5f1105b
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4ad31cb68cfa https://hg.mozilla.org/mozilla-central/rev/7189e5f1105b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/d81a217b8759 https://hg.mozilla.org/releases/mozilla-aurora/rev/61411310ed8a
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•