Closed
Bug 1256848
Opened 8 years ago
Closed 8 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_603750_websocket.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: linclark, Assigned: wldcordeiro, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file)
1.17 KB,
patch
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_603750_websocket.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
Assignee | ||
Comment 1•8 years ago
|
||
This patch fixes the eslint issues for `devtools/client/webconsole/test/browser_webconsole_bug_603750_websocket.js`
Attachment #8749347 -
Flags: review+
Attachment #8749347 -
Flags: feedback+
Comment 2•8 years ago
|
||
Comment on attachment 8749347 [details] [diff] [review] Bug1256848.patch Thanks Wellington. Setting the review flag to '?' and filling in a reviewer (in this case jlast).
Attachment #8749347 -
Flags: review?(jlaster)
Attachment #8749347 -
Flags: review+
Attachment #8749347 -
Flags: feedback+
Assignee | ||
Comment 3•8 years ago
|
||
Doh, I thought I did the right thing in the review/feedback column as those were the choices I saw when I clicked. Thanks Brian, I was actually just talking to jlast as I noticed linclark was on leave.
Comment 4•8 years ago
|
||
Wellington, I'm not familiar with `BrowserTestUtils.loadURI`, but if the tests run successfully, i believe it's okay. Do you know how to run the tests with try? Here's an overview, https://wiki.mozilla.org/ReleaseEngineering/TryServer#Getting_access_to_the_Try_Server. Let me know if you have any questions.
Comment 5•8 years ago
|
||
Comment on attachment 8749347 [details] [diff] [review] Bug1256848.patch Review of attachment 8749347 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/webconsole/test/browser_webconsole_bug_603750_websocket.js @@ +14,5 @@ > yield loadTab(TEST_URI2); > > let hud = yield openConsole(); > > + yield BrowserTestUtils.loadURI(gBrowser.selectedBrowser, TEST_URI); No need to yield here, since it wasn't before
Updated•8 years ago
|
Assignee: nobody → wellington
Status: NEW → ASSIGNED
Comment 6•8 years ago
|
||
(In reply to Jason Laster [:jlast] from comment #4) > Wellington, I'm not familiar with `BrowserTestUtils.loadURI`, but if the > tests run successfully, i believe it's okay. > > Do you know how to run the tests with try? Here's an overview, > https://wiki.mozilla.org/ReleaseEngineering/ > TryServer#Getting_access_to_the_Try_Server. Let me know if you have any > questions. I went ahead and pushed to try (with my suggested change in Comment 5 included): https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f6c558224c6
Comment 7•8 years ago
|
||
Wellington, assuming that try push looks good (usually takes an hour or two for it to finish), I can go ahead and push the patch without any extra work from you
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8fd42cc5e8c4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•8 years ago
|
Attachment #8749347 -
Flags: review?(jlaster)
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/8ebfcbda759e
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•