1256848 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_603750_websocket.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_603750_websocket.js

Comment 1

[Wellington Cordeiro [:wldcordeiro]]

Attachment: Bug1256848.patch

This patch fixes the eslint issues for `devtools/client/webconsole/test/browser_webconsole_bug_603750_websocket.js`

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8749347 [details] [diff] [review]
Bug1256848.patch

Thanks Wellington.  Setting the review flag to '?' and filling in a reviewer (in this case jlast).

Comment 3

[Wellington Cordeiro [:wldcordeiro]]

Doh, I thought I did the right thing in the review/feedback column as those were the choices I saw when I clicked. Thanks Brian, I was actually just talking to jlast as I noticed linclark was on leave.

Comment 4

[Jason Laster [:jlast]]

Wellington, I'm not familiar with `BrowserTestUtils.loadURI`, but if the tests run successfully, i believe it's okay.

Do you know how to run the tests with try? Here's an overview, https://wiki.mozilla.org/ReleaseEngineering/TryServer#Getting_access_to_the_Try_Server. Let me know if you have any questions.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8749347 [details] [diff] [review]
Bug1256848.patch

Review of attachment 8749347 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_webconsole_bug_603750_websocket.js
@@ +14,5 @@
>    yield loadTab(TEST_URI2);
>  
>    let hud = yield openConsole();
>  
> +  yield BrowserTestUtils.loadURI(gBrowser.selectedBrowser, TEST_URI);

No need to yield here, since it wasn't before

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Jason Laster [:jlast] from comment #4)
> Wellington, I'm not familiar with `BrowserTestUtils.loadURI`, but if the
> tests run successfully, i believe it's okay.
> 
> Do you know how to run the tests with try? Here's an overview,
> https://wiki.mozilla.org/ReleaseEngineering/
> TryServer#Getting_access_to_the_Try_Server. Let me know if you have any
> questions.

I went ahead and pushed to try (with my suggested change in Comment 5 included): https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f6c558224c6

Comment 7

[Brian Grinstead [:bgrins]]

Wellington, assuming that try push looks good (usually takes an hour or two for it to finish), I can go ahead and push the patch without any extra work from you

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8fd42cc5e8c4

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8fd42cc5e8c4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8ebfcbda759e