[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_646025_console_file_location.js

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: linclark, Assigned: mkohler, Mentored)

Tracking

unspecified
Firefox 49
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_646025_console_file_location.js
(Reporter)

Updated

a year ago
Blocks: 1256948
Priority: -- → P3
(Reporter)

Updated

a year ago
Whiteboard: [btpp-backlog]
(Assignee)

Comment 1

a year ago
Created attachment 8747456 [details] [diff] [review]
0001-Bug-1256863-ESLint-Fix-ESLint-issues-in-devtools-cli.patch
Assignee: nobody → me
Status: NEW → ASSIGNED
Attachment #8747456 - Flags: review?(lclark)
(Assignee)

Comment 2

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19bfa6c25e28
(Reporter)

Comment 3

a year ago
Comment on attachment 8747456 [details] [diff] [review]
0001-Bug-1256863-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747456 [details] [diff] [review]:
-----------------------------------------------------------------

I'm glad we're getting rid of so many CPOWs. This will probably clear up a bunch of intermittents along the way.

There's actually another way to do this that someone told me in a review of my code. Here's an example:

https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_658368_time_methods.js#62
Attachment #8747456 - Flags: review?(lclark)
(Assignee)

Comment 4

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2fbbe126415a
(Assignee)

Comment 5

a year ago
Created attachment 8747889 [details] [diff] [review]
0001-Bug-1256863-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=07cdc4be7841
Attachment #8747456 - Attachment is obsolete: true
Attachment #8747889 - Flags: review?(lclark)
(Reporter)

Comment 6

a year ago
Comment on attachment 8747889 [details] [diff] [review]
0001-Bug-1256863-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747889 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Feel free to add checkin-needed once it passes on try.
Attachment #8747889 - Flags: review?(lclark) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 7

a year ago
https://hg.mozilla.org/integration/fx-team/rev/8e8b4d74e547
Keywords: checkin-needed

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8e8b4d74e547
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Duplicate of this bug: 1265231

Comment 10

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/5108e581ac5c
status-firefox48: --- → fixed
You need to log in before you can comment on or make changes to this bug.