Closed Bug 1256863 Opened 5 years ago Closed 5 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_646025_console_file_location.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: mkohler, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file, 1 obsolete file)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_646025_console_file_location.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Assignee: nobody → me
Status: NEW → ASSIGNED
Attachment #8747456 - Flags: review?(lclark)
Comment on attachment 8747456 [details] [diff] [review]
0001-Bug-1256863-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747456 [details] [diff] [review]:
-----------------------------------------------------------------

I'm glad we're getting rid of so many CPOWs. This will probably clear up a bunch of intermittents along the way.

There's actually another way to do this that someone told me in a review of my code. Here's an example:

https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_658368_time_methods.js#62
Attachment #8747456 - Flags: review?(lclark)
Comment on attachment 8747889 [details] [diff] [review]
0001-Bug-1256863-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747889 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Feel free to add checkin-needed once it passes on try.
Attachment #8747889 - Flags: review?(lclark) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8e8b4d74e547
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.