Closed
Bug 1256863
Opened 8 years ago
Closed 8 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_646025_console_file_location.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: linclark, Assigned: mkohler, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file, 1 obsolete file)
849 bytes,
patch
|
linclark
:
review+
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_646025_console_file_location.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19bfa6c25e28
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8747456 [details] [diff] [review] 0001-Bug-1256863-ESLint-Fix-ESLint-issues-in-devtools-cli.patch Review of attachment 8747456 [details] [diff] [review]: ----------------------------------------------------------------- I'm glad we're getting rid of so many CPOWs. This will probably clear up a bunch of intermittents along the way. There's actually another way to do this that someone told me in a review of my code. Here's an example: https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_658368_time_methods.js#62
Attachment #8747456 -
Flags: review?(lclark)
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2fbbe126415a
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=07cdc4be7841
Attachment #8747456 -
Attachment is obsolete: true
Attachment #8747889 -
Flags: review?(lclark)
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8747889 [details] [diff] [review] 0001-Bug-1256863-ESLint-Fix-ESLint-issues-in-devtools-cli.patch Review of attachment 8747889 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! Feel free to add checkin-needed once it passes on try.
Attachment #8747889 -
Flags: review?(lclark) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e8b4d74e547
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/5108e581ac5c
status-firefox48:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•