[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_output_regexp.js

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: linclark, Assigned: acautin, Mentored)

Tracking

unspecified
Firefox 49
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_output_regexp.js
(Reporter)

Updated

a year ago
Blocks: 1256948
Priority: -- → P3
(Reporter)

Updated

a year ago
Whiteboard: [btpp-backlog]
(Assignee)

Comment 1

a year ago
Created attachment 8747434 [details] [diff] [review]
Bug-1256912-Fixed-eslint-errors-browser_webconsole_o.patch
Attachment #8747434 - Flags: review?(lclark)
Assignee: nobody → acautin
Status: NEW → ASSIGNED
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0263376aaf2
(Reporter)

Comment 3

a year ago
Comment on attachment 8747434 [details] [diff] [review]
Bug-1256912-Fixed-eslint-errors-browser_webconsole_o.patch

Review of attachment 8747434 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me... Thanks for the patch!
Attachment #8747434 - Flags: review?(lclark) → review+
(Reporter)

Updated

a year ago
Keywords: checkin-needed

Comment 4

a year ago
https://hg.mozilla.org/integration/fx-team/rev/01a6a967a600
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/01a6a967a600
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Comment 6

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/d17e4865654d
status-firefox48: --- → fixed
You need to log in before you can comment on or make changes to this bug.