Closed Bug 1256929 Opened 8 years ago Closed 8 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug_923281_test2.js

Categories

(DevTools :: Console, defect, P3)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: linclark, Assigned: hassan, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file)

1256929.patch
653 bytes, patch
linclark
: review+
Details | Diff | Splinter Review 
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-bug_923281_test2.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Attached patch 1256929.patch — — Splinter Review 

        Attachment #8779950 -
        Flags: review?(lclark)

    
  
Assignee: nobody → helfi92

    
    

    
  
(In reply to Hassan Ali from comment #2)
> Created attachment 8779950 [details] [diff] [review]
> 1256929.patch

Hello Lin, can you review this small patch for me?
Flags: needinfo?(lclark)

    
    

    
  
Comment on attachment 8779950 [details] [diff] [review]
1256929.patch

Review of attachment 8779950 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!

        Attachment #8779950 -
        Flags: review?(lclark) → review+

    
  
Flags: needinfo?(lclark)

    
  
Keywords: checkin-needed

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1692da30eb05
Fix ESLint error in test-bug_923281_test2.js. r=linclark
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1692da30eb05
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox51:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: