[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-595934-workers.js

RESOLVED FIXED in Firefox 52

Status

defect
P3
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: linclark, Assigned: jfr, Mentored)

Tracking

unspecified
Firefox 52
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment)

Reporter

Description

3 years ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-bug-595934-workers.js
Reporter

Updated

3 years ago
Blocks: 1256948
Priority: -- → P3
Reporter

Updated

3 years ago
Whiteboard: [btpp-backlog]
Assignee

Comment 1

3 years ago
hi there! i'd like to work on this bug, could you please assign it to me?
Comment hidden (mozreview-request)
Assignee: nobody → julia.friesel
(In reply to Julia Friesel[:jfr] from comment #1)
> hi there! i'd like to work on this bug, could you please assign it to me?

Hi Julia, thanks for the patch!  I've sent the code out to our CI system and will land it assuming all of the tests are passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d644e6ff8540

Comment 4

3 years ago
mozreview-review
Comment on attachment 8805754 [details]
Bug 1256932 - Fix ESLint issues in test-bug-595934-workers.js.

https://reviewboard.mozilla.org/r/89436/#review89844
Attachment #8805754 - Flags: review+
Mentor: jlaster, lclark → bgrinstead
Status: NEW → ASSIGNED

Comment 5

3 years ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ad230a32984
Fix ESLint issues in test-bug-595934-workers.js. r=bgrins

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0ad230a32984
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Attachment #8805754 - Flags: review?(jlaster)
Attachment #8805754 - Flags: review+

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.