Closed Bug 1256932 Opened 5 years ago Closed 4 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-595934-workers.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: linclark, Assigned: jfr, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-bug-595934-workers.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
hi there! i'd like to work on this bug, could you please assign it to me?
Assignee: nobody → julia.friesel
(In reply to Julia Friesel[:jfr] from comment #1)
> hi there! i'd like to work on this bug, could you please assign it to me?

Hi Julia, thanks for the patch!  I've sent the code out to our CI system and will land it assuming all of the tests are passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d644e6ff8540
Comment on attachment 8805754 [details]
Bug 1256932 - Fix ESLint issues in test-bug-595934-workers.js.

https://reviewboard.mozilla.org/r/89436/#review89844
Attachment #8805754 - Flags: review+
Mentor: jlaster, lclark → bgrinstead
Status: NEW → ASSIGNED
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ad230a32984
Fix ESLint issues in test-bug-595934-workers.js. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/0ad230a32984
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Attachment #8805754 - Flags: review?(jlaster)
Attachment #8805754 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.