1256932 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-595934-workers.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-bug-595934-workers.js

Comment 1

[Julia Friesel[:jfr]]

hi there! i'd like to work on this bug, could you please assign it to me?

Comment 2

[Julia Friesel[:jfr]]

Attachment: Bug 1256932 - Fix ESLint issues in test-bug-595934-workers.js.

Review commit: https://reviewboard.mozilla.org/r/89436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89436/

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Julia Friesel[:jfr] from comment #1)
> hi there! i'd like to work on this bug, could you please assign it to me?

Hi Julia, thanks for the patch!  I've sent the code out to our CI system and will land it assuming all of the tests are passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d644e6ff8540

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8805754 [details]
Bug 1256932 - Fix ESLint issues in test-bug-595934-workers.js.

https://reviewboard.mozilla.org/r/89436/#review89844

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ad230a32984
Fix ESLint issues in test-bug-595934-workers.js. r=bgrins

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0ad230a32984