Closed
Bug 1256933
Opened 10 years ago
Closed 9 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-597136-external-script-errors.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: linclark, Unassigned, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up
Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards
Then you can see the issues that need to be fixed by running
> eslint --no-ignore devtools/client/webconsole/test/test-bug-597136-external-script-errors.js
| Reporter | ||
Updated•10 years ago
|
Whiteboard: [btpp-backlog]
Comment 1•9 years ago
|
||
Hi Lin,
I would like to work on this bug, I have run that command and found 4 errors and 1 warning,
But I was just wondering the file only contains :
function f() {
bogus.g();
}
Not sure what it does, Can you please explain ?
And the errors + warnings are here:
6:1 warning Definition for rule 'mozilla/import-globals' was not found mozilla/import-globals
6:1 error Definition for rule 'mozilla/no-single-arg-cu-import' was not found mozilla/no-single-arg-cu-import
6:1 error Use the global form of 'use strict' strict
6:10 error 'f' is defined but never used no-unused-vars
7:3 error 'bogus' is not defined no-undef
Flags: needinfo?(lclark)
| Reporter | ||
Comment 2•9 years ago
|
||
Good questions. I think we can skip this file. It's just being pulled up in a test so the code style doesn't really matter.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(lclark)
Resolution: --- → INVALID
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•