Closed Bug 1256936 Opened 6 years ago Closed 5 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/test-bug-603750-websocket.js
Previous patch contained a typo in the commit message
Comment on attachment 8747440 [details] [diff] [review] 0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch Review of attachment 8747440 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks!
Attachment #8747440 - Flags: review?(lclark) → review+
Before we commit this, could you update the patch to include the reviewer? You can just change this: > Bug 1256936 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js To this: > Bug 1256936 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js. r=linclark
(I just added ". r=linclark" to the attachment description as requested in comment 5. No change otherwise, carrying over r+ from comment 4.)
Attachment #8747440 - Attachment is obsolete: true
Comment on attachment 8761270 [details] [diff] [review] 0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch (Actually carrying over r+ this time.)
Attachment #8761270 - Flags: review+
(Trivial rebase on top of https://hg.mozilla.org/mozilla-central/rev/c4b1eb619c41 )
No try because it's a simple non-functional change in syntax (but I verified it works locally just in case).
Pushed by email@example.com: https://hg.mozilla.org/integration/fx-team/rev/40635a4d3e9b [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js. r=linclark
You need to log in before you can comment on or make changes to this bug.