[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: linclark, Assigned: Fabien, Mentored)

Tracking

unspecified
Firefox 50
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed, firefox50 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

a year ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-bug-603750-websocket.js
(Reporter)

Updated

a year ago
Blocks: 1256948
Priority: -- → P3
(Reporter)

Updated

a year ago
Whiteboard: [btpp-backlog]
(Assignee)

Comment 1

a year ago
Created attachment 8747437 [details] [diff] [review]
0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch
Attachment #8747437 - Flags: review?(lclark)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0263376aaf2
Assignee: nobody → ab506032
(Assignee)

Comment 3

a year ago
Created attachment 8747440 [details] [diff] [review]
0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch

Previous patch contained a typo in the commit message
Attachment #8747437 - Attachment is obsolete: true
Attachment #8747437 - Flags: review?(lclark)
Attachment #8747440 - Flags: review?(lclark)
(Reporter)

Comment 4

a year ago
Comment on attachment 8747440 [details] [diff] [review]
0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch

Review of attachment 8747440 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8747440 - Flags: review?(lclark) → review+
(Reporter)

Comment 5

a year ago
Before we commit this, could you update the patch to include the reviewer?

You can just change this:

> Bug 1256936 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js

To this:

> Bug 1256936 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js. r=linclark
Created attachment 8761270 [details] [diff] [review]
0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch

(I just added ". r=linclark" to the attachment description as requested in comment 5. No change otherwise, carrying over r+ from comment 4.)
Attachment #8747440 - Attachment is obsolete: true
Comment on attachment 8761270 [details] [diff] [review]
0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch

(Actually carrying over r+ this time.)
Attachment #8761270 - Flags: review+
Created attachment 8761278 [details] [diff] [review]
0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch

(Trivial rebase on top of https://hg.mozilla.org/mozilla-central/rev/c4b1eb619c41 )
Attachment #8761270 - Attachment is obsolete: true
Attachment #8761278 - Flags: review+
No try because it's a simple non-functional change in syntax (but I verified it works locally just in case).
Keywords: checkin-needed

Comment 10

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/40635a4d3e9b
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js. r=linclark
Keywords: checkin-needed

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/40635a4d3e9b
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Comment 12

11 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/3217b202aab6
status-firefox49: --- → fixed

Comment 13

11 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/3fc47c0f759c
status-firefox48: --- → fixed
You need to log in before you can comment on or make changes to this bug.