Closed
Bug 1256936
Opened 7 years ago
Closed 7 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed, firefox50 fixed)
RESOLVED
FIXED
Firefox 50
People
(Reporter: linclark, Assigned: ab506032, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file, 3 obsolete files)
1.03 KB,
patch
|
janx
:
review+
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/test-bug-603750-websocket.js
Reporter | ||
Updated•7 years ago
|
Whiteboard: [btpp-backlog]
Attachment #8747437 -
Flags: review?(lclark)
Updated•7 years ago
|
Assignee: nobody → ab506032
Previous patch contained a typo in the commit message
Attachment #8747437 -
Attachment is obsolete: true
Attachment #8747437 -
Flags: review?(lclark)
Updated•7 years ago
|
Attachment #8747440 -
Flags: review?(lclark)
Reporter | ||
Comment 4•7 years ago
|
||
Comment on attachment 8747440 [details] [diff] [review] 0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch Review of attachment 8747440 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks!
Attachment #8747440 -
Flags: review?(lclark) → review+
Reporter | ||
Comment 5•7 years ago
|
||
Before we commit this, could you update the patch to include the reviewer? You can just change this: > Bug 1256936 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js To this: > Bug 1256936 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js. r=linclark
Comment 6•7 years ago
|
||
(I just added ". r=linclark" to the attachment description as requested in comment 5. No change otherwise, carrying over r+ from comment 4.)
Attachment #8747440 -
Attachment is obsolete: true
Comment 7•7 years ago
|
||
Comment on attachment 8761270 [details] [diff] [review] 0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch (Actually carrying over r+ this time.)
Attachment #8761270 -
Flags: review+
Comment 8•7 years ago
|
||
(Trivial rebase on top of https://hg.mozilla.org/mozilla-central/rev/c4b1eb619c41 )
Attachment #8761270 -
Attachment is obsolete: true
Attachment #8761278 -
Flags: review+
Comment 9•7 years ago
|
||
No try because it's a simple non-functional change in syntax (but I verified it works locally just in case).
Keywords: checkin-needed
Comment 10•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/40635a4d3e9b [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js. r=linclark
Keywords: checkin-needed
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/40635a4d3e9b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 12•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/3217b202aab6
status-firefox49:
--- → fixed
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/3fc47c0f759c
status-firefox48:
--- → fixed
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•