[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js

RESOLVED FIXED in Firefox 48

Status

defect
P3
normal
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: linclark, Assigned: ab506032, Mentored)

Tracking

unspecified
Firefox 50
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed, firefox50 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment, 3 obsolete attachments)

Reporter

Description

3 years ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-bug-603750-websocket.js
Reporter

Updated

3 years ago
Blocks: 1256948
Priority: -- → P3
Reporter

Updated

3 years ago
Whiteboard: [btpp-backlog]
Assignee

Comment 1

3 years ago
Attachment #8747437 - Flags: review?(lclark)
Assignee: nobody → ab506032
Assignee

Comment 3

3 years ago
Previous patch contained a typo in the commit message
Attachment #8747437 - Attachment is obsolete: true
Attachment #8747437 - Flags: review?(lclark)
Attachment #8747440 - Flags: review?(lclark)
Reporter

Comment 4

3 years ago
Comment on attachment 8747440 [details] [diff] [review]
0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch

Review of attachment 8747440 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8747440 - Flags: review?(lclark) → review+
Reporter

Comment 5

3 years ago
Before we commit this, could you update the patch to include the reviewer?

You can just change this:

> Bug 1256936 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js

To this:

> Bug 1256936 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js. r=linclark
(I just added ". r=linclark" to the attachment description as requested in comment 5. No change otherwise, carrying over r+ from comment 4.)
Attachment #8747440 - Attachment is obsolete: true
Comment on attachment 8761270 [details] [diff] [review]
0001-Last-Comment-Bug-1256936-ESLint-Fix-ESLint-issues-in.patch

(Actually carrying over r+ this time.)
Attachment #8761270 - Flags: review+
No try because it's a simple non-functional change in syntax (but I verified it works locally just in case).
Keywords: checkin-needed

Comment 10

3 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/40635a4d3e9b
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-603750-websocket.js. r=linclark
Keywords: checkin-needed

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/40635a4d3e9b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.