1256938 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-bug-766001-js-errors.js

Status: RESOLVED WONTFIX

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-bug-766001-js-errors.js

Comment 1

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256938-ESLint.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=edf7fcb4edd0

Comment 2

[Jason Laster [:jlast]]

Comment on attachment 8750032 [details] [diff] [review]
0001-Bug-1256938-ESLint.patch

looks good to me.

Comment 3

[Jason Laster [:jlast]]

Comment on attachment 8750032 [details] [diff] [review]
0001-Bug-1256938-ESLint.patch

Review of attachment 8750032 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, actually noticing that try chunk  dt8 is failing. 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=edf7fcb4edd0&selectedJob=20517735

You can re-run that chunk in try and see if it's a question of flakiness. If it is an error, you can run the tests with `.mach mochitest`

Comment 4

[Michael Kohler [:mkohler]]

Unfortunately, being realistic, I won't have time to finish this within the next few weeks. Therefore I'm un-assigning this again.

Comment 5

[Brian Grinstead [:bgrins]]

Closing unassigned webconsole test eslint bugs.  These tests will either be copied over and refactored for the new console frontend or removed and replaced with unit tests, so no sense in spending time fixing lint errors.  See bug 1308219.

Filter on NOVEMBERSEVENTH