1256939 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/test-console-count-external-file.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/test-console-count-external-file.js

Comment 1

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256939-ESLint.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=edf7fcb4edd0

Comment 2

[Jason Laster [:jlast]]

Looks good. Could you run try and then needinfo me?

Comment 3

[Michael Kohler [:mkohler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e182a2d1c5d6

Comment 4

[Michael Kohler [:mkohler]]

Looks good now

Comment 5

[Jason Laster [:jlast]]

Comment on attachment 8750031 [details] [diff] [review]
0001-Bug-1256939-ESLint.patch

Thanks.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f8be9723568a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f8be9723568a

Comment 8

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cf6da8d62404