[ESLint] Fix ESLint issues in devtools/client/webconsole/test/testscript.js

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: linclark, Assigned: mkohler, Mentored)

Tracking

unspecified
Firefox 49
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/testscript.js
(Reporter)

Updated

2 years ago
Blocks: 1256948
Priority: -- → P3
(Reporter)

Updated

2 years ago
Whiteboard: [btpp-backlog]
(Assignee)

Comment 2

2 years ago
Created attachment 8750026 [details] [diff] [review]
0001-Bug-1256942-ESLint.patch
Assignee: nobody → me
Attachment #8750026 - Flags: review?(jlaster)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
looks like dt8 is failing. mind re-running or running locally and then needinfoing me
(Assignee)

Comment 5

2 years ago
Looks good now.
Flags: needinfo?(jlaster)
Comment on attachment 8750026 [details] [diff] [review]
0001-Bug-1256942-ESLint.patch

Review of attachment 8750026 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8750026 - Flags: review?(jlaster) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/348a4f37b591
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Comment 9

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/e7f195b02a59
status-firefox48: --- → fixed
Comment on attachment 8750026 [details] [diff] [review]
0001-Bug-1256942-ESLint.patch

clearing as this is stale. If it is still relevant ping nchevobbe
Flags: needinfo?(jlaster)
Attachment #8750026 - Flags: review+
You need to log in before you can comment on or make changes to this bug.