Closed
Bug 1256942
Opened 8 years ago
Closed 8 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/testscript.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: linclark, Assigned: mkohler, Mentored)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file)
495 bytes,
patch
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/testscript.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=958272b2f634
Assignee | ||
Comment 2•8 years ago
|
||
Assignee: nobody → me
Attachment #8750026 -
Flags: review?(jlaster)
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 3•8 years ago
|
||
looks like dt8 is failing. mind re-running or running locally and then needinfoing me
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d505b3d3a147
Comment 6•8 years ago
|
||
Comment on attachment 8750026 [details] [diff] [review] 0001-Bug-1256942-ESLint.patch Review of attachment 8750026 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Attachment #8750026 -
Flags: review?(jlaster) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/348a4f37b591
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/e7f195b02a59
status-firefox48:
--- → fixed
Comment 10•6 years ago
|
||
Comment on attachment 8750026 [details] [diff] [review] 0001-Bug-1256942-ESLint.patch clearing as this is stale. If it is still relevant ping nchevobbe
Flags: needinfo?(jlaster)
Attachment #8750026 -
Flags: review+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•