Closed
Bug 1257036
Opened 8 years ago
Closed 8 years ago
security\sandbox\chromium\base/win/pe_image.h(250): warning C4302: 'reinterpret_cast': truncation from 'LPCSTR' to 'WORD' in staticruntime
Categories
(Core :: Security: Process Sandboxing, defect)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
This is similar to bug 1256490 except it occurs in the staticruntime.
Assignee | ||
Comment 1•8 years ago
|
||
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. But the warning occurs in third party code, so my hands are tied. Review commit: https://reviewboard.mozilla.org/r/40305/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40305/
Attachment #8731006 -
Flags: review?(bobowen.code)
Comment 2•8 years ago
|
||
Comment on attachment 8731006 [details] MozReview Request: Bug 1257036 - Disable C4302 to unblock compilation on VS2015; r?bobowen https://reviewboard.mozilla.org/r/40305/#review36883 ::: security/sandbox/staticruntime/moz.build:35 (Diff revision 1) > if CONFIG['_MSC_VER']: > CXXFLAGS += [ > '-wd4275', # non dll-interface class exception used as base for dll-interface class > '-wd4717', # recursive on all control paths, function will cause runtime stack overflow > '-wd4996', # 'GetVersionExW': was declared deprecated > + '-wd4302', # 'reinterpret_cast': truncation from 'LPCSTR' to 'WORD' nit: trailing whitespace
Attachment #8731006 -
Flags: review?(bobowen.code) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8731006 [details] MozReview Request: Bug 1257036 - Disable C4302 to unblock compilation on VS2015; r?bobowen Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40305/diff/1-2/
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2837103f30fb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•