Closed Bug 1257036 Opened 4 years ago Closed 4 years ago
_image .h(250): warning C4302: 'reinterpret _cast': truncation from 'LPCSTR' to 'WORD' in staticruntime
58 bytes, text/x-review-board-request
This is similar to bug 1256490 except it occurs in the staticruntime.
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. But the warning occurs in third party code, so my hands are tied. Review commit: https://reviewboard.mozilla.org/r/40305/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40305/
Attachment #8731006 - Flags: review?(bobowen.code)
Comment on attachment 8731006 [details] MozReview Request: Bug 1257036 - Disable C4302 to unblock compilation on VS2015; r?bobowen https://reviewboard.mozilla.org/r/40305/#review36883 ::: security/sandbox/staticruntime/moz.build:35 (Diff revision 1) > if CONFIG['_MSC_VER']: > CXXFLAGS += [ > '-wd4275', # non dll-interface class exception used as base for dll-interface class > '-wd4717', # recursive on all control paths, function will cause runtime stack overflow > '-wd4996', # 'GetVersionExW': was declared deprecated > + '-wd4302', # 'reinterpret_cast': truncation from 'LPCSTR' to 'WORD' nit: trailing whitespace
Attachment #8731006 - Flags: review?(bobowen.code) → review+
Comment on attachment 8731006 [details] MozReview Request: Bug 1257036 - Disable C4302 to unblock compilation on VS2015; r?bobowen Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40305/diff/1-2/
You need to log in before you can comment on or make changes to this bug.