1257046 - Upgrade sipe to 1.20.1

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

Attachment: sipe.diff

This updates sipe and then reapplies our patches: http://hg.mozilla.org/users/florian_queze.net/purple/rev/783630602d6f

This compiles for me on Mac, but I wasn't able to test it as I no longer have an Office Communicator account.

Comment 1

[aleth [:aleth]]

Comment on attachment 8731013 [details] [diff] [review]
sipe.diff

Review of attachment 8731013 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to rs this unless you have something you'd specifically like me to look at.

Looks like we have at least one user who will be happy to test this ;)

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8731013 [details] [diff] [review]
sipe.diff

Review of attachment 8731013 [details] [diff] [review]:
-----------------------------------------------------------------

I did another review on this, specifically looking for if this enables features we had explicitly disabled previously.

Comment 3

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/users/florian_queze.net/purple/rev/69428cd068a1
https://hg.mozilla.org/users/florian_queze.net/purple/rev/d8a03ccd5d66

I also pushed a follow-up which removes a few files in sipe/core which are used for tests...which we don't run nor compile.

Comment 4

[Patrick Cloke [:clokep]]

Follow-up to build on Windows https://hg.mozilla.org/users/florian_queze.net/purple/rev/6476bd54c5ca