Use jit/arm64/Architecture-arm64.h on non-JIT aarch64

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

45 Branch
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1253216 +++

We should use Architecture-arm64.h if aarch64 platfrom without jit.  (Now, jit is disabled on aarch64 platfrom)
(Assignee)

Comment 1

3 years ago
Created attachment 8731023 [details] [diff] [review]
Use jit/arm64/Architecture-arm64.h on non-JIT aarch64
(Assignee)

Comment 2

3 years ago
Comment on attachment 8731023 [details] [diff] [review]
Use jit/arm64/Architecture-arm64.h on non-JIT aarch64

Follow up Bug 1253216.

You know, aarch64 is turned off Ion JIT.  We already has AtomicOperations-arm64.h, so even if non-JIT, we should use it.

And, including jit/arm64/Architecture-arm64.h on jit/arm64/AtomicOperations-arm64.h is unnecessary.  And if including it without JS_CODEGE_ARM64, it causes build error due to conflict of jit/none/Architecture-none.h.
Attachment #8731023 - Flags: review?(lhansen)

Comment 3

3 years ago
Comment on attachment 8731023 [details] [diff] [review]
Use jit/arm64/Architecture-arm64.h on non-JIT aarch64

Review of attachment 8731023 [details] [diff] [review]:
-----------------------------------------------------------------

OK, since the ARM64 JIT is stuck in traffic behind SIMD and Wasm.

I'm going to file a bug reminding myself to remove this code again once the ARM64 JIT is finished.
Attachment #8731023 - Flags: review?(lhansen) → review+

Updated

3 years ago
See Also: → bug 1257125
(Assignee)

Updated

3 years ago
Assignee: nobody → m_kato

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a5919256fd5c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.