Closed Bug 1257055 Opened 4 years ago Closed 4 years ago

Use jit/arm64/Architecture-arm64.h on non-JIT aarch64

Categories

(Core :: JavaScript Engine: JIT, defect)

45 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1253216 +++

We should use Architecture-arm64.h if aarch64 platfrom without jit.  (Now, jit is disabled on aarch64 platfrom)
Comment on attachment 8731023 [details] [diff] [review]
Use jit/arm64/Architecture-arm64.h on non-JIT aarch64

Follow up Bug 1253216.

You know, aarch64 is turned off Ion JIT.  We already has AtomicOperations-arm64.h, so even if non-JIT, we should use it.

And, including jit/arm64/Architecture-arm64.h on jit/arm64/AtomicOperations-arm64.h is unnecessary.  And if including it without JS_CODEGE_ARM64, it causes build error due to conflict of jit/none/Architecture-none.h.
Attachment #8731023 - Flags: review?(lhansen)
Comment on attachment 8731023 [details] [diff] [review]
Use jit/arm64/Architecture-arm64.h on non-JIT aarch64

Review of attachment 8731023 [details] [diff] [review]:
-----------------------------------------------------------------

OK, since the ARM64 JIT is stuck in traffic behind SIMD and Wasm.

I'm going to file a bug reminding myself to remove this code again once the ARM64 JIT is finished.
Attachment #8731023 - Flags: review?(lhansen) → review+
See Also: → 1257125
Assignee: nobody → m_kato
https://hg.mozilla.org/mozilla-central/rev/a5919256fd5c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.