Closed Bug 1257067 Opened 4 years ago Closed 4 years ago

Replace XF86XK keysyms with GDK keysyms in nsWindow::OnKeyPressEvent

Categories

(Core :: Widget: Gtk, defect)

Unspecified
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: m_kato, Assigned: tyamaguchi.gentoo)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Our minimum requirement of GTK2 is 2.18.0.   By https://git.gnome.org/browse/gtk+/commit/gdk/gdkkeysyms.h?h=2.18.0&id=11898088a1ac30eff17e7f24dd906aba476ae384 and https://bugzilla.gnome.org/show_bug.cgi?id=594668, many XF86keysym is defined into GDK.

So we can replace XF86XK with GDK_ keysym.
Whiteboard: [good first bug]
Assignee: nobody → tyamaguchi.gentoo
Comment on attachment 8735056 [details]
MozReview Request: Bug 1257067 - modified XF86XK_ keysyms to GDK_ ones r?masayuki

https://reviewboard.mozilla.org/r/42541/#review39067

Thank you, Yamaguchi-san. Probably, this is enough safe to land, but I'll land this after tryserver tests.
Attachment #8735056 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/82d365a9a1b4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.