1257095 - bootstrap.py fails on arch linux with ImportError: No module named 'StringIO'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[sbforman]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160308181531

Steps to reproduce:

i opened up my terminal and typed:
wget -q https://hg.mozilla.org/mozilla-central/raw-file/default/python/mozboot/bin/bootstrap.py -O bootstrap.py && python bootstrap.py

i am runing Linux arche 4.4.3-1-ARCH


Actual results:

this was returned in terminal:

Traceback (most recent call last):
  File "bootstrap.py", line 19, in <module>
    from StringIO import StringIO
ImportError: No module named 'StringIO'

also a file named "bootstrap.py" was downloaded in the same derectory where the comand was run. when i try  python bootstrap.py i get the same error as above.


Expected results:

i was trying to build firefox for the first time.

Comment 1

[sbforman]

this fails with python 3 my defalt. but works with python2

Comment 2

[Gregory Szorc [:gps]]

We should rewrite the bootstrapper to work on Python 3.

A quick fix would be to have the bootstrapper detect when it is running on Python 3 and print an error message saying to run on Python 2. I don't like that fix because people may need to figure out how to install Python 2. But it is better than print a stack.

Comment 3

[Nathan Hakkakzadeh [:Nat]]

Attachment: MozReview Request: Bug 1257095 - Bootstrapper now checks if Python interpreter is version 2.6 or 2.7 so users get a readable error instead of a stack trace. r?gps

Should be a stopgap until bootstrapper is ported to Python 3.

Review commit: https://reviewboard.mozilla.org/r/54948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54948/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8756082 [details]
MozReview Request: Bug 1257095 - Bootstrapper now checks if Python interpreter is version 2.6 or 2.7 so users get a readable error instead of a stack trace. r?gps

https://reviewboard.mozilla.org/r/54948/#review51618

::: python/mozboot/bin/bootstrap.py:18
(Diff revision 1)
>  # If we add unicode_literals, optparse breaks on Python 2.6.1 (which is needed
>  # to support OS X 10.6).
> +
> +import sys
> +if sys.version_info[:2] not in [(2, 6), (2, 7)]:
> +    print("Python 2.6 or 2.7 is currently required to run bootstrap. Please re-run with `python2.7` or `python2`")

I'm going to bikeshed the message a bit here.

We want it to be a bit actionable. So how about a more detailed message saved in a ''' string:

Bootstrap currently only runs on Python 2.7 or Python 2.6. Please try re-running with `python2.7` or `python2.6`.

If these aren't available on your system, you may need to install them. Look for a "python2" or "python27" package in your package manager.

::: python/mozboot/bin/bootstrap.py:19
(Diff revision 1)
>  # to support OS X 10.6).
> +
> +import sys
> +if sys.version_info[:2] not in [(2, 6), (2, 7)]:
> +    print("Python 2.6 or 2.7 is currently required to run bootstrap. Please re-run with `python2.7` or `python2`")
> +    sys.exit()

sys.exit(1) to indicate failure.

::: python/mozboot/bin/bootstrap.py:21
(Diff revision 1)
> +import sys
> +if sys.version_info[:2] not in [(2, 6), (2, 7)]:
> +    print("Python 2.6 or 2.7 is currently required to run bootstrap. Please re-run with `python2.7` or `python2`")
> +    sys.exit()
> +
>  from __future__ import print_function

The `__future__` import special in that it must be the first statement in a Python module to have an effect IIRC. So the new code needs to come after this import.

Comment 5

[Nathan Hakkakzadeh [:Nat]]

Comment on attachment 8756082 [details]
MozReview Request: Bug 1257095 - Bootstrapper now checks if Python interpreter is version 2.6 or 2.7 so users get a readable error instead of a stack trace. r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54948/diff/1-2/

Comment 6

[Nathan Hakkakzadeh [:Nat]]

Comment on attachment 8756082 [details]
MozReview Request: Bug 1257095 - Bootstrapper now checks if Python interpreter is version 2.6 or 2.7 so users get a readable error instead of a stack trace. r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54948/diff/2-3/

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8756082 [details]
MozReview Request: Bug 1257095 - Bootstrapper now checks if Python interpreter is version 2.6 or 2.7 so users get a readable error instead of a stack trace. r?gps

https://reviewboard.mozilla.org/r/54948/#review51634

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b946d6af2776

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b946d6af2776