Closed Bug 1257100 Opened 4 years ago Closed 4 years ago

Report we can play type 'audio/mp4; codecs="mp4a.40.29"'

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(1 file)

We can play HE-AACv2, but MEdiaSource.isTypeSupported("audio/mp4; codecs=\"mp4a.40.29\"") return false. Ditto for HTMLMediaElement.canPlayType().
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Comment on attachment 8731077 [details] [diff] [review]
Report we can play type 'audio/mp4; codecs=mp4a.40.29'

Review of attachment 8731077 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/test/test_can_play_type_mpeg.html
@@ +75,5 @@
>    check("audio/mp4; codecs=\"mp4a.40.5\"", "probably");
>    check("audio/mp4; codecs=mp4a.40.5", "probably");
>    check("audio/x-m4a; codecs=\"mp4a.40.5\"", "probably");
>    check("audio/x-m4a; codecs=mp4a.40.5", "probably");
> +  

white space, can remove CR too.
Attachment #8731077 - Flags: review?(jyavenard) → review+
https://hg.mozilla.org/mozilla-central/rev/1114b55d0da2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8731077 [details] [diff] [review]
Report we can play type 'audio/mp4; codecs=mp4a.40.29'

Approval Request Comment
[Feature/regressing bug #]: MSE video on Facebook
[User impact if declined]: Facebook will have to deploy a work around to get MediaSource video to work in Firefox.
[Describe test coverage new/current, TreeHerder]: we have tests to cover this feature, and the additions being made here.
[Risks and why]: Low, this is just basically adding a new value to our set of values being compared against.
[String/UUID change made/needed]: none.
Attachment #8731077 - Flags: approval-mozilla-beta?
Attachment #8731077 - Flags: approval-mozilla-aurora?
Comment on attachment 8731077 [details] [diff] [review]
Report we can play type 'audio/mp4; codecs=mp4a.40.29'

MSE video on FB, Aurora47+, Beta46+
Attachment #8731077 - Flags: approval-mozilla-beta?
Attachment #8731077 - Flags: approval-mozilla-beta+
Attachment #8731077 - Flags: approval-mozilla-aurora?
Attachment #8731077 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.