Closed
Bug 1257100
Opened 9 years ago
Closed 9 years ago
Report we can play type 'audio/mp4; codecs="mp4a.40.29"'
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: cpearce, Assigned: cpearce)
Details
Attachments
(1 file)
|
1.84 KB,
patch
|
jya
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We can play HE-AACv2, but MEdiaSource.isTypeSupported("audio/mp4; codecs=\"mp4a.40.29\"") return false. Ditto for HTMLMediaElement.canPlayType().
| Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8731077 -
Flags: review?(jyavenard)
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8731077 [details] [diff] [review]
Report we can play type 'audio/mp4; codecs=mp4a.40.29'
Review of attachment 8731077 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/media/test/test_can_play_type_mpeg.html
@@ +75,5 @@
> check("audio/mp4; codecs=\"mp4a.40.5\"", "probably");
> check("audio/mp4; codecs=mp4a.40.5", "probably");
> check("audio/x-m4a; codecs=\"mp4a.40.5\"", "probably");
> check("audio/x-m4a; codecs=mp4a.40.5", "probably");
> +
white space, can remove CR too.
Attachment #8731077 -
Flags: review?(jyavenard) → review+
| Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1114b55d0da25b717aa02c7a4d9fc9b0efb53bf1
Bug 1257100 - Report we can play type 'audio/mp4; codecs=mp4a.40.29'. r=jya
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
| Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8731077 [details] [diff] [review]
Report we can play type 'audio/mp4; codecs=mp4a.40.29'
Approval Request Comment
[Feature/regressing bug #]: MSE video on Facebook
[User impact if declined]: Facebook will have to deploy a work around to get MediaSource video to work in Firefox.
[Describe test coverage new/current, TreeHerder]: we have tests to cover this feature, and the additions being made here.
[Risks and why]: Low, this is just basically adding a new value to our set of values being compared against.
[String/UUID change made/needed]: none.
Attachment #8731077 -
Flags: approval-mozilla-beta?
Attachment #8731077 -
Flags: approval-mozilla-aurora?
Comment on attachment 8731077 [details] [diff] [review]
Report we can play type 'audio/mp4; codecs=mp4a.40.29'
MSE video on FB, Aurora47+, Beta46+
Attachment #8731077 -
Flags: approval-mozilla-beta?
Attachment #8731077 -
Flags: approval-mozilla-beta+
Attachment #8731077 -
Flags: approval-mozilla-aurora?
Attachment #8731077 -
Flags: approval-mozilla-aurora+
status-firefox46:
--- → affected
status-firefox47:
--- → affected
| Assignee | ||
Comment 7•9 years ago
|
||
| bugherder uplift | ||
| Assignee | ||
Comment 8•9 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•